Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing feature allowing custom hostname/URL override for desktop pairing endpoints. While the implementation is well-tested and self-contained to the settings UI, new feature capabilities warrant human review to verify the intended behavior and UX are appropriate. You can customize Macroscope's approvability policy. Learn more. |
|
3rd commit is me merging main into this because this branch was a bit behind. no merge conflicts. |
|
@juliusmarminge Not to spam but I think this fix is good, let me know |
|
The connection catalog and current pairing endpoint-selection design supersede this custom-endpoint implementation, and its linked issue is closed. This was closed as part of a large repo-wide maintenance sweep. If you think it's still relevant, please reopen. |
What Changed
Adds a small, scoped fix for multi-NIC setups in Settings → Manage local backend → Network access:
apps/web/src/components/settings/networkEndpointOverride.tsapps/web/src/components/settings/networkEndpointOverride.test.tsapps/web/src/components/settings/SettingsPanels.browser.tsxWhy
On hosts with multiple interfaces/IPs (for example VPN/WireGuard + LAN), the auto-selected reachable address can be wrong for the user’s target device. That makes the displayed “Reachable at” value and copied pairing URL require manual edits.
This change provides a minimal, user-controlled override without changing backend exposure behavior or introducing persistent settings complexity.
UI Changes
Before:
After:
Screenshot:
Checklist
Fixes issue #2031
Note
Low Risk
Low risk: scoped UI-only change that rewrites the displayed/copy pairing endpoint via small parsing logic, with fallback + validation and added tests.
Overview
Adds an optional Custom hostname or URL override in
ConnectionsSettings(shown only when desktop network access is enabled) to replace the auto-detected endpoint used in the “Reachable at …” label and in generated/copied pairing links.Introduces
resolveDesktopNetworkEndpointUrlto parse/validate host or full-URL overrides (with inline error + fallback to the default endpoint), and adds unit + browser tests to cover the override and copy-to-clipboard behavior.Reviewed by Cursor Bugbot for commit 4fccbbd. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add custom network endpoint override for desktop pairing links
resolveDesktopNetworkEndpointUrlto parse and validate the user-provided hostname or URL, returning an effective endpoint, a normalization flag, and an inline validation error when the input is invalid.Macroscope summarized 4fccbbd.