Skip to content

perf(web): usePreviewBridge compiles with the React Compiler #20644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 17, 2026
Merged

perf(web): usePreviewBridge compiles with the React Compiler #20644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions apps/web/src/components/preview/usePreviewBridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {
} from "@t3tools/contracts";
import { parseScopedThreadKey, scopedThreadKey } from "@t3tools/client-runtime/environment";
import * as Option from "effect/Option";
import { useEffect, useEffectEvent, useMemo, useRef } from "react";
import { useEffect, useEffectEvent, useRef } from "react";

import {
flushPendingFaviconsForThread,
Expand Down Expand Up @@ -43,13 +43,8 @@ export function usePreviewBridge(input: {
const { threadRef, tabId, runtimeTabId, serverDriven = false } = input;
const clearBrowserPointer = useBrowserPointerStore((state) => state.clear);
const reportStatus = useAtomCommand(previewEnvironment.reportStatus, "preview status report");
const bridge = previewBridge;
const threadKey = scopedThreadKey(threadRef);
const stableThreadRef = useMemo(() => {
const parsed = parseScopedThreadKey(threadKey);
if (!parsed) throw new Error(`Invalid scoped thread key: ${threadKey}`);
return parsed;
}, [threadKey]);
const stableThreadRef = useThreadRefForKey(threadKey);
const projectRef = useFaviconProjectRefForThread(stableThreadRef);
const preparedConnection = usePreparedConnection(stableThreadRef.environmentId);
const environmentHostname = Option.isSome(preparedConnection)
Expand Down Expand Up @@ -87,18 +82,31 @@ export function usePreviewBridge(input: {
},
);
useEffect(() => {
if (!bridge || typeof window === "undefined") return;
if (!previewBridge || typeof window === "undefined") return;
lastReportedUrl.current = null;
lastReportedKind.current = null;
lastDesktopNavStatus.current = null;
return bridge.onStateChange(handleStateChange);
}, [bridge, runtimeTabId, stableThreadRef, tabId]);
return previewBridge.onStateChange(handleStateChange);
}, [
// oxlint-disable-next-line react/exhaustive-effect-dependencies -- A different tab or thread starts its status reports and pointer tracking from scratch.
runtimeTabId,
stableThreadRef,
tabId,
]);
useEffect(() => {
if (!projectRef) return;
flushPendingFaviconsForThread(stableThreadRef, projectRef, environmentHostname);
}, [environmentHostname, projectRef, stableThreadRef]);
}

// Callers pass a fresh threadRef each render; the key keeps the ref stable for the effects.
function useThreadRefForKey(threadKey: string): ScopedThreadRef {
"use memo";
const parsed = parseScopedThreadKey(threadKey);
if (!parsed) throw new Error(`Invalid scoped thread key: ${threadKey}`);
return parsed;
}

function shouldClearBrowserPointer(
previous: DesktopPreviewTabState["navStatus"] | null,
current: DesktopPreviewTabState["navStatus"],
Expand Down
Loading