Repository navigation
fix(mobile): read-only thread rows keep their side inset - #19944
Closed
ipanasenko wants to merge 2 commits into
Closed
ipanasenko wants to merge 2 commits into
ipanasenko wants to merge 2 commits into
Conversation
ipanasenko
marked this pull request as ready for review
October 15, 2026 16:59
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-file mobile UI fix preserves read-only behavior while restoring the established container insets and clipping, with no schema, infrastructure, security, billing, or static-analysis impact. The runtime scope is limited to row presentation. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Member
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo Closing: #21071 shipped this same change. Rows that cannot be operated are now wrapped in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, a thread row gets its 8dp side inset from the swipe wrapper's container style. A row whose environment session lacks operate scope (for example, while that environment reconnects) skipped the wrapper and lost the inset. Those rows sat closer to the screen edge than rows from connected environments.
ArchivedThreadsScreenalready wraps its read-only rows this way.Evidence
After: Wasn't able to check on a device.
apps/mobiletypecheck passes.thread-list-v2-row-appearance.test.tspasses (12/12).Merge Danger
Door: two-way
Blast Radius: Small
Layout only. Android read-only rows get the same inset, vertical margin, and rounded clip as operable rows. iOS home rows get an undefined style (no change). iOS sidebar read-only rows now clip to the 12pt corner radius, the same as operable rows.
Made with Claude Opus 5.5 in T3 Code (Claude Code harness).