Skip to content

fix(web): Mod+T opens the tab menu while a pull request tab is open #19065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 5 commits into from
Oct 20, 2026
Merged

fix(web): Mod+T opens the tab menu while a pull request tab is open #19065

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ac18bf
fix(web): Mod+T opens the tab menu while a pull request tab is open
riccardopll Oct 9, 2026
956c0f4
test(web): keep Mod+T blocked while a popup is closing
riccardopll Oct 11, 2026
e371174
Merge main into Mod+T pull request shortcut fix
juliusmarminge Oct 19, 2026
72af418
fix(web): ignore closed popups for panel shortcuts
juliusmarminge Oct 19, 2026
8ee86b7
Merge remote-tracking branch 'origin/main' into riccardo/fix-mod-t-pr…
juliusmarminge Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions apps/web/src/components/RightPanelTabs.keyboard.browser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ describe("right panel new-tab shortcut", () => {
expect((await press("t", { metaKey: true, isComposing: true })).defaultPrevented).toBe(false);
const dialog = document.createElement("div");
dialog.dataset.slot = "dialog-popup";
dialog.dataset.open = "";
container.append(dialog);
for (const state of ["data-open", "data-ending-style"]) {
dialog.setAttribute(state, "");
Expand All @@ -229,6 +230,35 @@ describe("right panel new-tab shortcut", () => {
}
});

it("blocks panel shortcuts until a mounted popup finishes closing", async () => {
await renderPanel();
const popover = document.createElement("div");
popover.dataset.slot = "popover-popup";
popover.dataset.open = "";
container.append(popover);

expect((await press("t", { metaKey: true })).defaultPrevented).toBe(false);
expect((await press("f")).defaultPrevented).toBe(false);
expect(document.querySelector('[role="menu"]')).toBeNull();
expect(addFiles).not.toHaveBeenCalled();

delete popover.dataset.open;
popover.dataset.closed = "";
popover.dataset.endingStyle = "";
expect((await press("t", { metaKey: true })).defaultPrevented).toBe(false);
expect((await press("f")).defaultPrevented).toBe(false);
expect(document.querySelector('[role="menu"]')).toBeNull();
expect(addFiles).not.toHaveBeenCalled();

delete popover.dataset.endingStyle;
popover.hidden = true;
expect((await press("f")).defaultPrevented).toBe(true);
expect(addFiles).toHaveBeenCalledOnce();
expect((await press("t", { metaKey: true })).defaultPrevented).toBe(true);
expect(document.querySelector('[role="menu"]')?.textContent).toContain("Files");
expect(document.activeElement?.closest('[role="menu"]')).not.toBeNull();
});

it("supports arrow keys with an existing tab in sheet mode and clears the menu on close", async () => {
const panel = {
mode: "sheet" as const,
Expand Down
Loading