Skip to content

fix(web): hide the empty reset badge on unstarted limit windows - #18579

Open
akash3444 wants to merge 1 commit into
pingdotgg:mainfrom
akash3444:fix/web-hide-empty-reset-badge
Open

akash3444 wants to merge 1 commit into
pingdotgg:mainfrom
akash3444:fix/web-hide-empty-reset-badge

Conversation

@akash3444

Copy link
Copy Markdown
Contributor

Problem

On Usage → Limits, a Claude Session window that hasn't started yet (no message sent in the current 5‑hour window) shows an empty white pill at the right end of its bar. Expected: no badge, since there is no countdown and no reset credits to show.

Change

Until the first message, Claude reports resets_at: null for the 5‑hour window, so formatResetsIn returns null and there are no banked credits. PoolSegment still rendered the badge plate (bg-background/85 px-1.5 py-0.5) with nothing inside. The plate now renders only when there is a countdown or banked credits.

Scope and approval

Very small, focused fix for an obvious visual bug: one conditional around an existing element in apps/web/src/components/usage/UsageLimitsPooled.tsx. No behavior or data changes. Split out of #18570 per the one-problem rule.

Verification

Checked in the dev desktop app (vp run dev:desktop) against a copy of real usage data, at 2×. The local Claude session was already active, so to reproduce the "not started" state I temporarily patched the dev server to report the 5‑hour window with no reset time. That patch is not part of this PR. Weekly windows, which always have a reset time, still show their badge. Mobile doesn't use this component.

Before After
Session bar with an empty pill on the right Session bar with no badge

Claude Opus 5.5 via Claude Code in T3 Code.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 12, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 12, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d67c5be

Macroscope's review found this PR approvable — This is a focused one-file UI fix that hides an empty reset badge while preserving countdown and credit displays. Its runtime impact is limited to presentation of the existing pooled usage component, with no schema, infrastructure, security, billing, or static-analysis changes.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bf70c48-023c-464b-b98d-1c707ea9e140

📥 Commits

Reviewing files that changed from the base of the PR and between 5d59e71 and d67c5be.


📒 Files selected for processing (1)
  • apps/web/src/components/usage/UsageLimitsPooled.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.



📝 Walkthrough

Walkthrough

The pooled usage segment now shows its countdown and reset-credit plate only when a reset countdown or credits are present. If neither is present, the segment omits the plate.

Changes

Pooled usage display

Layer / File(s) Summary
Conditional reset plate
apps/web/src/components/usage/UsageLimitsPooled.tsx
The countdown and reset-credit plate appears when resetsIn or credits is truthy. Otherwise, the segment omits it.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge


Merge Risk: ⚪ Minimal · up to d67c5

The empty reset plate is hidden while countdowns and banked credits remain visible. No material merge risk remains.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: hiding the empty reset badge for unstarted limit windows. It uses a conventional commit format.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the bug, implementation, focused-scope rationale, reproduction method, observed result…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 12, 2026 — with ChatGPT Codex Connector
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 12, 2026 08:18

Dismissing prior approval to re-evaluate d67c5be

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants