Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file UI fix that hides an empty reset badge while preserving countdown and credit displays. Its runtime impact is limited to presentation of the existing pooled usage component, with no schema, infrastructure, security, billing, or static-analysis changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
October 12, 2026 08:18
Dismissing prior approval to re-evaluate d67c5be
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Usage → Limits, a Claude Session window that hasn't started yet (no message sent in the current 5‑hour window) shows an empty white pill at the right end of its bar. Expected: no badge, since there is no countdown and no reset credits to show.
Change
Until the first message, Claude reports
resets_at: nullfor the 5‑hour window, soformatResetsInreturnsnulland there are no banked credits.PoolSegmentstill rendered the badge plate (bg-background/85 px-1.5 py-0.5) with nothing inside. The plate now renders only when there is a countdown or banked credits.Scope and approval
Very small, focused fix for an obvious visual bug: one conditional around an existing element in
apps/web/src/components/usage/UsageLimitsPooled.tsx. No behavior or data changes. Split out of #18570 per the one-problem rule.Verification
Checked in the dev desktop app (
vp run dev:desktop) against a copy of real usage data, at 2×. The local Claude session was already active, so to reproduce the "not started" state I temporarily patched the dev server to report the 5‑hour window with no reset time. That patch is not part of this PR. Weekly windows, which always have a reset time, still show their badge. Mobile doesn't use this component.Claude Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code