Repository navigation
Conversation
The per-thread maximization migration removed the local state setter but left the OS-link maximize effect calling it, breaking web typecheck. Apply consumed requests to the same environment-scoped thread in the store so maximization survives navigation. Verified web-only typecheck, 85 focused existing tests, and targeted lint and formatting.
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped CI/typecheck fix in one component, replacing a removed local setter with the existing per-thread right-panel store update. It restores the intended maximize-request behavior without changing defaults, schemas, production infrastructure, or static-analysis configuration. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Author
|
Closing as redundant: the same maximize-request store fix landed in #16619, and main CI is now passing. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI is failing web typecheck with
ChatView.tsx(6059,7): TS2304 Cannot find name 'setMaximizedRightPanelThreadKey': failing main run. The right-panel state migration in #17327 removed that React setter but left the OS-link maximize-request effect calling it. This also breaks unrelated PRs whose ChatView is unchanged from main.Apply the consumed request with
setMaximized(routeThreadRef, true)in the right-panel store and remove the redundant effect dependency. Request consumption and the update use the same environment-scoped thread ref. The existing panel-availability guard and one-shot request behavior are preserved, and maximization stays with the thread when navigating away and back.This is a small, focused fix for an obvious compile error and qualifies for the contribution guide's small-fix exception. Only the missed store migration is changed.
Validation with Node 24.19.0 and a temporary dependency overlay matching the relevant lockfile versions, with workspace imports pointing to this worktree:
tsc --noEmit -p apps/web/tsconfig.json(build info directed outside source): reproduced the exact TS2304 before the fix; passed after it.vp test run apps/web/src/rightPanelStore.test.ts apps/web/src/hooks/useActiveThreadRef.test.tsx: 85 existing tests passed, covering thread/environment isolation, retained maximization, restoration, and active-thread refs.vp lint apps/web/src/components/ChatView.tsx --report-unused-disable-directives: passed with existing warnings outside the changed effect.vp fmt --check apps/web/src/components/ChatView.tsxandgit diff --check: passed.Web and desktop share this component. Browser, native desktop, and mobile verification were not performed; this fixes compilation and preserves the existing maximize-request behavior. No provider, server, or wire-contract changes are required.
Model: GPT-6.1-Sol. Harness: Codex in T3 Code.