Skip to content

fix(web): fix CI typecheck for right-panel maximize requests - #17803

Closed
extoci wants to merge 1 commit into
pingdotgg:mainfrom
extoci:t3/local-ci-right-panel-regression
Closed

extoci wants to merge 1 commit into
pingdotgg:mainfrom
extoci:t3/local-ci-right-panel-regression

Conversation

@extoci

@extoci extoci commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Main CI is failing web typecheck with ChatView.tsx(6059,7): TS2304 Cannot find name 'setMaximizedRightPanelThreadKey': failing main run. The right-panel state migration in #17327 removed that React setter but left the OS-link maximize-request effect calling it. This also breaks unrelated PRs whose ChatView is unchanged from main.

Apply the consumed request with setMaximized(routeThreadRef, true) in the right-panel store and remove the redundant effect dependency. Request consumption and the update use the same environment-scoped thread ref. The existing panel-availability guard and one-shot request behavior are preserved, and maximization stays with the thread when navigating away and back.

This is a small, focused fix for an obvious compile error and qualifies for the contribution guide's small-fix exception. Only the missed store migration is changed.

Validation with Node 24.19.0 and a temporary dependency overlay matching the relevant lockfile versions, with workspace imports pointing to this worktree:

  • Web-only tsc --noEmit -p apps/web/tsconfig.json (build info directed outside source): reproduced the exact TS2304 before the fix; passed after it.
  • vp test run apps/web/src/rightPanelStore.test.ts apps/web/src/hooks/useActiveThreadRef.test.tsx: 85 existing tests passed, covering thread/environment isolation, retained maximization, restoration, and active-thread refs.
  • Targeted vp lint apps/web/src/components/ChatView.tsx --report-unused-disable-directives: passed with existing warnings outside the changed effect.
  • Targeted vp fmt --check apps/web/src/components/ChatView.tsx and git diff --check: passed.

Web and desktop share this component. Browser, native desktop, and mobile verification were not performed; this fixes compilation and preserves the existing maximize-request behavior. No provider, server, or wire-contract changes are required.

Model: GPT-6.1-Sol. Harness: Codex in T3 Code.

The per-thread maximization migration removed the local state setter but left the OS-link maximize effect calling it, breaking web typecheck. Apply consumed requests to the same environment-scoped thread in the store so maximization survives navigation.

Verified web-only typecheck, 85 focused existing tests, and targeted lint and formatting.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 10, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 78768ee

Macroscope's review found this PR approvable — This is a narrowly scoped CI/typecheck fix in one component, replacing a removed local setter with the existing per-thread right-panel store update. It restores the intended maximize-request behavior without changing defaults, schemas, production infrastructure, or static-analysis configuration.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 38d0ce20-e2be-4b0e-b6da-7bc6ec14fd1f

📥 Commits

Reviewing files that changed from the base of the PR and between de49d63 and 78768ee.


📒 Files selected for processing (1)
  • apps/web/src/components/ChatView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.



📝 Walkthrough

Walkthrough

ChatView now consumes a maximize request for the route thread and sets that thread’s panel state to maximized through useRightPanelStore.

Changes

Right panel maximize

Layer / File(s) Summary
Apply maximize request
apps/web/src/components/ChatView.tsx
When the right panel can be maximized, the effect consumes the request for the route thread and maximizes its panel through useRightPanelStore. It no longer updates local thread-key state.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge


Merge Risk: ⚪ Minimal · up to 78768

Maximize requests are applied to the matching route thread, including after navigation changes. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 78768

The change affects 1 system.

Changed systems: apps/web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/web (ui) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/web/src/components/ChatView.tsx: The effect now consumes a maximize request for routeThreadRef and maximizes that thread through useRightPanelStore; it no longer records the thread key in local state.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title is concise, specific, and accurately identifies the web CI typecheck fix for right-panel maximize requests.
Description check Passed The description clearly explains the compile error, root cause, code change, scope exception, focused verification, test results, and unperformed platform checks.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@extoci

extoci commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing as redundant: the same maximize-request store fix landed in #16619, and main CI is now passing. Thanks!

@extoci extoci closed this Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant