Repository navigation
Conversation
Antigravity usage scans resolved ANTIGRAVITY_DATA_DIR from the host environment only, so an instance configured with its own data directory had its history omitted. Resolve the data roots from each instance's merged environment; the existing canonical directory set still counts shared and aliased roots once. Refs pingdotgg#17631. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This change alters production usage scanning by making per-instance data-directory configuration determine which history databases are traversed and aggregated. The scope is focused and tested, but the configuration-driven processing change warrants human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
October 11, 2026 06:20
Dismissing prior approval to re-evaluate a977b9e
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Antigravity usage scans receive the configured provider instances but resolved
ANTIGRAVITY_DATA_DIRfrom the host environment once. An Antigravity instance configured with its ownANTIGRAVITY_DATA_DIRhad its history omitted.Change
Resolve the data roots from each instance's already merged environment. The implicit default instance still carries the host environment, so the host override and the built-in defaults keep working. The existing canonical conversation-directory set still counts shared and aliased roots once. T3-managed profile directories are unchanged.
Refs #17631.
Scope and approval
#17631 was filed by maintainer Julius for the same gap in OpenCode and notes that "Antigravity and Cursor are worth checking for the same gap." The OpenCode fix is #17759. This PR is the Antigravity half only, kept separate under the one-problem rule.
Cursor is not included. Its usage reader reads one account per environment from the host's Cursor CLI login by design (
packages/provider-cursor/src/server/driver.ts, "One account source per environment"), so per-instance accounts would be a product change rather than the same bug.Verification
macOS, Node 25.9.0; temporary directories, no live provider history.
UsageService.test.ts: two configured Antigravity instances with distinctANTIGRAVITY_DATA_DIRvalues (one with surrounding whitespace and an empty comma entry). Before the fix it fails: the scan reports three sources (host root plus two profile directories) and neither instance directory. After the fix both instance directories are scanned.vp test run apps/server/src/usage/UsageService.test.ts apps/server/src/provider/Drivers/antigravityUsageReader.test.ts apps/server/src/provider/Drivers/AntigravityDriver.test.ts: 51 passed. The existing aliased-root test (ANTIGRAVITY_DATA_DIRon the host with two aliases) still counts one source.tsc --noEmit -p apps/server/tsconfig.json: no errors. Scopedvp lintandvp fmt --checkon the two changed files passed.git diff --checkpassed.Windows was not executed.
Implemented with Claude Opus 5.5 through Claude Code in T3 Code.
🤖 Generated with Claude Code