Skip to content

refactor(provider-core): move the driver interface into provider-core - #17283

Closed
juliusmarminge wants to merge 1 commit into
t3/provider-corefrom
t3/provider-core-server
Closed

juliusmarminge wants to merge 1 commit into
t3/provider-corefrom
t3/provider-core-server

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Every driver implements an interface that lived inside apps/server, so no driver could live in its own package.

This moves the driver contract into @t3tools/provider-core/server/*: the driver and instance records, the V2 adapter shape and its errors, selection transitions, the snapshot shape, the auth controller, the text-generation operations, maintenance capabilities, and ProviderDriverError. Server modules that implemented these keep their services and re-export the moved types. The adapter's Effect service key follows its new module path (an in-memory tag; nothing persists it).

No behavior change.


Part of the provider-packages stack: #17282 → #17283 → #17284 → #17285 → #17286 → #17287 → #17288.

Done by Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

Provider drivers implemented an interface that lived inside apps/server,
so no driver could live in its own package. Move the driver contract into
@t3tools/provider-core/server/*: the driver and instance records, the V2
adapter shape and its errors, selection transitions, the snapshot shape,
the auth controller, text generation operations, maintenance capabilities,
and ProviderDriverError.

Server modules that implemented these keep their services and re-export
the moved types, so callers outside the provider boundary are unchanged.
The adapter service key now matches its new module path.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.2 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 474e92e · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Superseded by the squashed 3-PR stack #17299 → #17300 → #17302 (same changes, regrouped; Effect service modules renamed to PascalCase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant