Skip to content

fix(web): semantic prefix hint lines up with its settings row - #17001

Closed
BRTZL wants to merge 3 commits into
pingdotgg:mainfrom
BRTZL:fix/source-control-semantic-padding
Closed

BRTZL wants to merge 3 commits into
pingdotgg:mainfrom
BRTZL:fix/source-control-semantic-padding

Conversation

@BRTZL

@BRTZL BRTZL commented Oct 7, 2026

Copy link
Copy Markdown

Problem

In Settings → Source Control → Text generation, choosing "Semantic prefix" for "Worktree branch naming" shows a hint ("The model chooses a prefix that describes the work…"). That hint was rendered as a bare paragraph between settings rows, so it had no horizontal padding, sat flush against the card edge under its own divider, and used a larger font than every other description in the section.

Reproduce: open Settings → Source Control, set "Worktree branch naming" to "Semantic prefix".

Change

The hint now goes through the mode row's existing status slot in SettingsRow instead of being a sibling paragraph. It inherits the row's padding and the small muted text style, and the stray divider is gone. It still only shows for semantic mode and stays hidden when the selected targets have mixed modes.

Scope and approval

Very small, focused fix for an obvious visual bug: one file, layout only, no behavior, contract, or default changes. No prior issue or discussion.

Verification

Manual check in the web client (vp run dev, 1280×800, light theme), same page and state before and after:

Before After
Before: hint flush against the card edge, larger text, own divider After: hint inside the row, padded, small muted text
  • Switched between "Static prefix", "Semantic prefix" and "Custom instructions": the hint shows only for semantic, and the static and custom rows are unchanged.
  • tsc --noEmit in apps/web passes; vp lint and vp fmt --check pass on the changed file.

Not checked: the desktop shell (it wraps the same web component), dark theme, narrow container widths, and a mixed multi-environment selection. Mobile is unaffected: its branch naming settings use a separate component with per-option descriptions.

Claude Opus 5.5 (1M context) via Claude Code in T3 Code.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 7, 2026
@BRTZL
BRTZL force-pushed the fix/source-control-semantic-padding branch from 7744b3a to c98af67 Compare October 7, 2026 23:42
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1598edd1-2dd6-40cf-aa11-e097a9dadd16
📥 Commits

Reviewing files that changed from the base of the PR and between 9f89f9d and 296d490.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41b224e7-6c7f-4a29-9825-39faa912c4be
📥 Commits

Reviewing files that changed from the base of the PR and between 3143335 and c98af67.

📒 Files selected for processing (1)
  • apps/web/src/components/settings/BranchNamingSettings.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

When branch naming uses semantic mode and is not mixed, the setting displays the semantic-prefix explanation as its status. The separate explanatory paragraph is removed.

Changes

Branch naming settings

Layer / File(s) Summary
Show semantic-mode explanation in settings
apps/web/src/components/settings/BranchNamingSettings.tsx
The setting displays the semantic-prefix explanation as its status when the mode is semantic and not mixed. The separate paragraph is removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to c98af

The semantic-prefix hint remains limited to semantic, non-mixed selections and now uses the settings row’s status styling. No material merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main UI fix: aligning the semantic-prefix hint with its settings row.
Description check ✅ Passed The description includes all required sections. It explains the problem and reproduction steps, the implementation, scope and approval rationale, focused verification results, screenshots, and uncheck…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Approvability ✅ Passed PASS. The pull request changes only apps/web/src/components/settings/BranchNamingSettings.tsx. It moves existing semantic-prefix text into the existing SettingsRow.status slot and removes the sibl…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge

Copy link
Copy Markdown
Member

Note

Grok responding on behalf of Julius.

Superseded by merged #16972, which already landed the same semantic branch naming hint alignment fix. Closing this PR; please reopen if it still has unique changes beyond that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants