Repository navigation
Conversation
7744b3a to
c98af67
Compare
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughWhen branch naming uses semantic mode and is not mixed, the setting displays the semantic-prefix explanation as its status. The separate explanatory paragraph is removed. ChangesBranch naming settings
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The semantic-prefix hint remains limited to semantic, non-mixed selections and now uses the settings row’s status styling. No material merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Note Grok responding on behalf of Julius. Superseded by merged #16972, which already landed the same semantic branch naming hint alignment fix. Closing this PR; please reopen if it still has unique changes beyond that fix. |
Problem
In Settings → Source Control → Text generation, choosing "Semantic prefix" for "Worktree branch naming" shows a hint ("The model chooses a prefix that describes the work…"). That hint was rendered as a bare paragraph between settings rows, so it had no horizontal padding, sat flush against the card edge under its own divider, and used a larger font than every other description in the section.
Reproduce: open Settings → Source Control, set "Worktree branch naming" to "Semantic prefix".
Change
The hint now goes through the mode row's existing
statusslot inSettingsRowinstead of being a sibling paragraph. It inherits the row's padding and the small muted text style, and the stray divider is gone. It still only shows for semantic mode and stays hidden when the selected targets have mixed modes.Scope and approval
Very small, focused fix for an obvious visual bug: one file, layout only, no behavior, contract, or default changes. No prior issue or discussion.
Verification
Manual check in the web client (
vp run dev, 1280×800, light theme), same page and state before and after:tsc --noEmitinapps/webpasses;vp lintandvp fmt --checkpass on the changed file.Not checked: the desktop shell (it wraps the same web component), dark theme, narrow container widths, and a mixed multi-environment selection. Mobile is unaffected: its branch naming settings use a separate component with per-option descriptions.
Claude Opus 5.5 (1M context) via Claude Code in T3 Code.