Skip to content

fix(windows): skip stale child process cleanup #16850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krarilotus wants to merge 1 commit into
base: main
Choose a base branch
from
+63 −3
Open

fix(windows): skip stale child process cleanup #16850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions patches/@effect__platform-node-shared@4.0.1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
diff --git a/dist/NodeChildProcessSpawner.js b/dist/NodeChildProcessSpawner.js
--- a/dist/NodeChildProcessSpawner.js
+++ b/dist/NodeChildProcessSpawner.js
@@ -44,9 +44,16 @@
return false;
}
};
-const taskkill = (childProcess, onExit = () => {}) => NodeChildProcess.execFile("taskkill", ["/pid", String(childProcess.pid), "/T", "/F"], {
- windowsHide: true
-}, onExit);
+const taskkill = (childProcess, onExit = () => {}) => {
+ // An exited leader's PID cannot safely identify its former Windows tree.
+ if (childProcess.exitCode !== null || childProcess.signalCode !== null) {
+ onExit(null);
+ return;
+ }
+ NodeChildProcess.execFile("taskkill", ["/pid", String(childProcess.pid), "/T", "/F"], {
+ windowsHide: true
+ }, onExit);
+};
const make = /*#__PURE__*/Effect.gen(function* () {
const fs = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
diff --git a/src/NodeChildProcessSpawner.ts b/src/NodeChildProcessSpawner.ts
--- a/src/NodeChildProcessSpawner.ts
+++ b/src/NodeChildProcessSpawner.ts
@@ -19,7 +19,9 @@
* `forceKillAfter`, the wait is limited to one second and never escalates.
* With it, cleanup may take the configured duration plus a final one-second
* wait after `SIGKILL`. Zombie descendants can consume either full bound. On
- * Windows, `taskkill` terminates the tree and only the leader's exit is awaited.
+ * Windows, `taskkill` terminates the tree while the leader is running and only
+ * the leader's exit is awaited. Descendants that outlive the leader are not
+ * reclaimed by PID-based cleanup.
*
* POSIX cleanup targets a numeric process-group ID. If the group disappears
* and its ID is reused before cleanup, an unrelated group may be signalled.
@@ -98,13 +100,19 @@
const taskkill = (
childProcess: NodeChildProcess.ChildProcess,
onExit: (error: NodeChildProcess.ExecException | null) => void = () => {}
-) =>
+) => {
+ // An exited leader's PID cannot safely identify its former Windows tree.
+ if (childProcess.exitCode !== null || childProcess.signalCode !== null) {
+ onExit(null)
+ return
+ }
NodeChildProcess.execFile(
"taskkill",
["/pid", String(childProcess.pid!), "/T", "/F"],
{ windowsHide: true },
onExit
)
+}

const make = Effect.gen(function*() {
const fs = yield* FileSystem.FileSystem
7 changes: 4 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ packageExtensions:
vite-plus: "catalog:"

patchedDependencies:
"@effect/platform-node-shared@4.0.1": patches/@effect__platform-node-shared@4.0.1.patch
alchemy@2.0.0-beta.80: patches/alchemy@2.0.0-beta.80.patch
expo-glass-effect@58.0.3: patches/expo-glass-effect@58.0.3.patch
expo-blur@58.0.3: patches/expo-blur@58.0.3.patch
Expand Down
Loading