Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This focused one-line CSS-class change rounds the trailing PR checks hover surface without changing application logic or existing control behavior. Its impact is limited to presentation in the web thread-details panel. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe split-checks style now rounds the trailing end of the last segment. ChangesThread details panel styling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change is limited to the checks segment’s trailing corner styling and does not alter when checks appear. No merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing to recreate this PR from my personal account with the same fix and screenshots. |
|
Replaced by #16548 from my personal account. This PR stays closed. |
The checks button at the end of a thread details PR row paints a square hover surface over the row's rounded edge. Neighboring editor and Git action controls already round their outer corners.
Add
last:rounded-e-lgto the checks segment. It rounds the outer edge only when checks end the row. Checks before aFixorMergeaction keep square inner corners. This is a small, focused fix for an obvious visual bug, with no product behavior change.Verification
pnpm exec vp run dev --home-dir /Users/nandakumar/Personal/t3code/.t3.0px. After: right corners measure10px; left corners stay0px.Fixaction still measure0pxon all corners.pnpm exec vp test run apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts: 181 tests pass.pnpm exec vp lint apps/web/src/components/chat/threadDetailsPanelStyles.ts: passes.pnpm --filter @t3tools/web typecheck: passes.pnpm --filter @t3tools/web build: passes, with chunk-size warnings.Verified in the web client on macOS. Desktop uses this same web component; Electron and native mobile were not tested. Mobile viewport resizing timed out in the Browser panel. Node is v26.7.0; the repository requests ^24.13.1.
Nightlies build from
main, not a separate nightly branch, so this PR targetsmain.Before / after
Screenshots show the same hovered button in the dev server. The crops enlarge the panel without changing its content. Evidence lives in the fork's evidence-only prerelease, not in the code diff.
Model: GPT-6.1 Sol (
openai/gpt-6.1-sol). Harness: OpenCode through T3 Code.