Repository navigation
Conversation
Submitting owner/ in Add Project sent that string to repository lookup and showed a generic failure. Ask for the full owner/repository name instead. Co-authored-by: Cursor <cursoragent@cursor.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrow input-validation fix that replaces a generic lookup failure for incomplete GitHub owner paths with a clear web/mobile error, while leaving valid inputs and other providers unchanged. The shared helper is unit-tested, and the PR does not alter defaults, schemas, security-sensitive code, or static-analysis settings. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughAdds a shared validation helper for incomplete GitHub owner paths. The mobile add-project screen and web command palette use it to stop repository lookup when the input lacks a repository name. ChangesGitHub repository input validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested reviewers: Merge Risk: ⚪ Minimal · up to The incomplete-path guard has no identified issue that needs to be resolved before merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Problem
In Add Project, submitting a GitHub path that is only
owner/(orowner//) calls repository lookup. GitHub cannot resolve that input, and the UI shows a generic lookup failure.Change
Before lookup, GitHub input that is only an owner plus a trailing slash now stops. Web shows a toast titled "Repository name incomplete" with "Enter the full owner/repository name." Mobile shows that same sentence in the existing error banner.
Complete
owner/repositorynames, bare repository names, GitHub URLs, and SSH URLs still go to lookup. Other providers are unchanged. This does not list an owner's repositories.Web and mobile both use the same check because both submit Add Project lookups.
Scope and approval
This is the focused input-validation fix split out of closed #10214, as requested in #10214 (comment). Repository discovery stays out of this PR. It is a small correction of an existing failure: incomplete input should not be sent to lookup.
Verification
vp test run packages/client-runtime/src/operations/projects.test.ts— 18 passed, includingowner/,owner//, complete names, URLs, and non-GitHub sources.vp linton the four touched files — no new warnings.vp run --filter @t3tools/client-runtime typecheck,@t3tools/web, and@t3tools/mobile— passed.I did not capture a live before/after screenshot. The web message uses the same toast as the current lookup failure, and the mobile message uses the existing error banner.
Implemented with Grok 4.7 via the Cursor harness.
Made with Cursor