Repository navigation
fix(web): usage title lines up with the titlebar on narrow windows - #15952
MatthewFeroz wants to merge 1 commit into
Conversation
Below the xl breakpoint the usage header wraps its controls onto a second row, which left the breadcrumb top-aligned in an auto-height header instead of centered on the titlebar with the sidebar toggle and window controls. Keep the breadcrumb row at the titlebar height so it stays aligned. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-file responsive layout adjustment only changes Usage page alignment below the xl breakpoint while preserving the existing wide layout. It uses existing titlebar sizing tokens and introduces no schema, security, deployment, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Usage page top bar now uses responsive layout rules. The breadcrumb has a fixed height below extra-large widths and automatic height at extra-large widths. ChangesUsage page top bar
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established in this responsive header change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Note Grok responding on behalf of Julius. Thanks for this! The same Usage header misalignment on narrow windows was just fixed on main by #15552, which keeps the breadcrumb and the compact controls on one 52px row so the title lines up with the sidebar header. Closing this one as superseded. If you still see the breadcrumb off-center after #15552, please open an issue with a screenshot. |
Problem
When the window is narrower than the
xlbreakpoint (1280px), the Usage page header wraps its controls (metric, period, refresh) onto a second row and grows taller than the titlebar. TheUsage / All environmentsbreadcrumb then sits at the top of that taller header. It ends up 8px above the sidebar toggle (and above the macOS traffic lights in desktop), which stay centered on the 52px titlebar.To reproduce, open Usage in a window narrower than 1280px with the sidebar collapsed.
Change
In the wrapped layout, the breadcrumb row is now exactly
--workspace-topbar-heighttall and centers its content, so it lines up with the titlebar controls. The controls row stays below it. The single-rowxllayout is unchanged.Because the fix uses the shared titlebar-height variable, it also holds on Windows with the window-controls overlay, where that height comes from
env(titlebar-area-height).Scope and approval
This is a one-file, CSS-only fix for an obvious visual misalignment on one page, with no behavior change. It qualifies as a very small, focused fix of an obvious bug, so there is no linked issue.
Verification
Before and after were captured in the same flow: the real web app, the same dev server and data, Limits view, sidebar collapsed, 880px viewport. For "before", only
UsagePage.tsxwas temporarily reverted tomain.The dashed line marks the sidebar toggle's vertical center. Measured with
getBoundingClientRect:Full screenshots
Before
After
vp lintandvp fmtpass on the changed file.WorkspacePageHeaderand titlebar-height variable that this fix aligns to.🤖 Generated with Claude Code (Claude Opus 5.5)