Skip to content

fix(mobile): back from a finished subagent in the feed returns to its parent - #15844

Merged
Yash-Singh1 merged 1 commit into
pingdotgg:mainfrom
AKolenda:fix/mobile-subagent-worklog-back-to-parent
Oct 5, 2026
Merged

Yash-Singh1 merged 1 commit into
pingdotgg:mainfrom
AKolenda:fix/mobile-subagent-worklog-back-to-parent

Conversation

@AKolenda

@AKolenda AKolenda commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #15068.

#15068 fixed the live subagent group card (thread-subagent-group.tsx) to push the agent's thread so Android back returns to the parent. But that card only shows while agents are running. Once an agent finishes, the entry point is the "Subagent … finished" row in the thread work log (thread-work-log.tsx), which still called navigate("Thread") — that reuses the current Thread route, drops the parent from the stack, and sends back straight to Home.

This flips that one call to StackActions.push, matching #15068, so opening a finished subagent from the feed and pressing back returns to the parent thread.

Before / after (Pixel 9, Android 17)

Opening the finished "Scan Supabase backend" subagent, then pressing back — left is current behaviour, right is this PR:

before and after

Note: the "Open agents" sheet (ThreadAgentsSheet.tsx) intentionally uses StackActions.replace and is left as-is.

Built with Claude Opus 5.5.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 5, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 9fe527e

Macroscope's review found this PR approvable — This is a small, self-contained mobile navigation bug fix that changes only the subagent-thread transition from route reuse to stack push, preserving the parent thread for back navigation. No product defaults, schemas, infrastructure, or static-analysis overrides are involved.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad1862df-d0da-416c-877b-4862c4449515
📥 Commits

Reviewing files that changed from the base of the PR and between ed5b29b and 9f6f8be.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef52399d-5852-4b93-a038-c52cabd4723e
📥 Commits

Reviewing files that changed from the base of the PR and between 01f894e and 9fe527e.

📒 Files selected for processing (1)
  • apps/mobile/src/features/threads/thread-work-log.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Pressing a work-log row for a subagent notification now pushes the notified thread onto the navigation stack. The route receives the same environment and thread IDs.

Changes

Subagent thread navigation

Layer / File(s) Summary
Push the notified thread
apps/mobile/src/features/threads/thread-work-log.tsx
The notification row dispatches StackActions.push to the Thread route with the environment and notified thread IDs.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 9fe52

The notified subagent opens above its parent thread, so returning from it preserves the intended parent-thread navigation. No merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the navigation fix for finished subagents and is specific to the main change.
Description check ✅ Passed The description explains the problem and change, identifies the focused scope, and reports a device check with before-and-after evidence. It mostly covers the required template.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@AKolenda
AKolenda force-pushed the fix/mobile-subagent-worklog-back-to-parent branch from 9fe527e to ed5b29b Compare October 5, 2026 02:40
@AKolenda

AKolenda commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

Hey @Yash-Singh1 — small follow-up to #15068. Forgot to make back work from the finished "Subagent … finished" row in the feed (thread-work-log.tsx), so it still popped to Home there. Pushes it now like the group card does.

… parent

pingdotgg#15068 pushed the agent's thread from the live subagent group card, but the
"Subagent … finished" work-log row in the thread feed still called
navigate("Thread"), which reuses the current Thread route. Opening a finished
subagent that way dropped the parent from the stack, so back went straight to
Home. Push it instead, matching the group card.
@AKolenda
AKolenda force-pushed the fix/mobile-subagent-worklog-back-to-parent branch from ed5b29b to 9f6f8be Compare October 5, 2026 07:32
@Yash-Singh1
Yash-Singh1 merged commit 1604ccc into pingdotgg:main Oct 5, 2026
28 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 5, 2026
## What's Changed
* fix(prs): queue fast actions and close batches by dragging by @maria-rcks in pingdotgg/t3code#15851
* perf(prs): share concurrent github routing metadata probes by @maria-rcks in pingdotgg/t3code#15853
* fix(mobile): back from a finished subagent in the feed returns to its parent by @AKolenda in pingdotgg/t3code#15844
* fix(desktop): bound preview inspector retention and record renderer identity by @maria-rcks in pingdotgg/t3code#16032
* fix(web): show fast mode beside reasoning as text by @maria-rcks in pingdotgg/t3code#16069
* fix(mobile): make the routes list match the other settings rows by @juliusmarminge in pingdotgg/t3code#15958
* fix(threads): stop pull request watches when settling by @Bil0000 in pingdotgg/t3code#16095
* feat(contracts): clients tolerate union members they don't know yet by @juliusmarminge in pingdotgg/t3code#15951
* refactor(contracts): project icons decode forward-compatibly instead of encoding a fallback by @juliusmarminge in pingdotgg/t3code#16118
* Removed an unused helper from the Android push payload builder by @kridaydave in pingdotgg/t3code#16116
* perf(mobile): reduce shell cache encoding work by @juliusmarminge in pingdotgg/t3code#15096
* perf(mobile): defer audio recorder creation until dictation by @juliusmarminge in pingdotgg/t3code#15248
* feat(server): bump Antigravity ACP agent to 1.3.0 by @Droyder7 in pingdotgg/t3code#15746
* feat(acp): support local provider commands by @maria-rcks in pingdotgg/t3code#16021
* fix(server): honor submodule settings when creating worktrees by @BlankParticle in pingdotgg/t3code#15594

## New Contributors
* @Droyder7 made their first contribution in pingdotgg/t3code#15746
* @BlankParticle made their first contribution in pingdotgg/t3code#15594

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261005.2676...v0.0.46-nightly.20261005.2689

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2689
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 5, 2026
## What's Changed
* fix(prs): queue fast actions and close batches by dragging by @maria-rcks in pingdotgg/t3code#15851
* perf(prs): share concurrent github routing metadata probes by @maria-rcks in pingdotgg/t3code#15853
* fix(mobile): back from a finished subagent in the feed returns to its parent by @AKolenda in pingdotgg/t3code#15844
* fix(desktop): bound preview inspector retention and record renderer identity by @maria-rcks in pingdotgg/t3code#16032
* fix(web): show fast mode beside reasoning as text by @maria-rcks in pingdotgg/t3code#16069
* fix(mobile): make the routes list match the other settings rows by @juliusmarminge in pingdotgg/t3code#15958
* fix(threads): stop pull request watches when settling by @Bil0000 in pingdotgg/t3code#16095
* feat(contracts): clients tolerate union members they don't know yet by @juliusmarminge in pingdotgg/t3code#15951
* refactor(contracts): project icons decode forward-compatibly instead of encoding a fallback by @juliusmarminge in pingdotgg/t3code#16118
* Removed an unused helper from the Android push payload builder by @kridaydave in pingdotgg/t3code#16116
* perf(mobile): reduce shell cache encoding work by @juliusmarminge in pingdotgg/t3code#15096
* perf(mobile): defer audio recorder creation until dictation by @juliusmarminge in pingdotgg/t3code#15248
* feat(server): bump Antigravity ACP agent to 1.3.0 by @Droyder7 in pingdotgg/t3code#15746
* feat(acp): support local provider commands by @maria-rcks in pingdotgg/t3code#16021
* fix(server): honor submodule settings when creating worktrees by @BlankParticle in pingdotgg/t3code#15594

## New Contributors
* @Droyder7 made their first contribution in pingdotgg/t3code#15746
* @BlankParticle made their first contribution in pingdotgg/t3code#15594

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261005.2676...v0.0.46-nightly.20261005.2689

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants