fix(mobile): back from a finished subagent in the feed returns to its parent - #15844
Yash-Singh1 merged 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained mobile navigation bug fix that changes only the subagent-thread transition from route reuse to stack push, preserving the parent thread for back navigation. No product defaults, schemas, infrastructure, or static-analysis overrides are involved. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughPressing a work-log row for a subagent notification now pushes the notified thread onto the navigation stack. The route receives the same environment and thread IDs. ChangesSubagent thread navigation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The notified subagent opens above its parent thread, so returning from it preserves the intended parent-thread navigation. No merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
9fe527e to
ed5b29b
Compare
|
Hey @Yash-Singh1 — small follow-up to #15068. Forgot to make back work from the finished "Subagent … finished" row in the feed ( |
… parent pingdotgg#15068 pushed the agent's thread from the live subagent group card, but the "Subagent … finished" work-log row in the thread feed still called navigate("Thread"), which reuses the current Thread route. Opening a finished subagent that way dropped the parent from the stack, so back went straight to Home. Push it instead, matching the group card.
ed5b29b to
9f6f8be
Compare
## What's Changed * fix(prs): queue fast actions and close batches by dragging by @maria-rcks in pingdotgg/t3code#15851 * perf(prs): share concurrent github routing metadata probes by @maria-rcks in pingdotgg/t3code#15853 * fix(mobile): back from a finished subagent in the feed returns to its parent by @AKolenda in pingdotgg/t3code#15844 * fix(desktop): bound preview inspector retention and record renderer identity by @maria-rcks in pingdotgg/t3code#16032 * fix(web): show fast mode beside reasoning as text by @maria-rcks in pingdotgg/t3code#16069 * fix(mobile): make the routes list match the other settings rows by @juliusmarminge in pingdotgg/t3code#15958 * fix(threads): stop pull request watches when settling by @Bil0000 in pingdotgg/t3code#16095 * feat(contracts): clients tolerate union members they don't know yet by @juliusmarminge in pingdotgg/t3code#15951 * refactor(contracts): project icons decode forward-compatibly instead of encoding a fallback by @juliusmarminge in pingdotgg/t3code#16118 * Removed an unused helper from the Android push payload builder by @kridaydave in pingdotgg/t3code#16116 * perf(mobile): reduce shell cache encoding work by @juliusmarminge in pingdotgg/t3code#15096 * perf(mobile): defer audio recorder creation until dictation by @juliusmarminge in pingdotgg/t3code#15248 * feat(server): bump Antigravity ACP agent to 1.3.0 by @Droyder7 in pingdotgg/t3code#15746 * feat(acp): support local provider commands by @maria-rcks in pingdotgg/t3code#16021 * fix(server): honor submodule settings when creating worktrees by @BlankParticle in pingdotgg/t3code#15594 ## New Contributors * @Droyder7 made their first contribution in pingdotgg/t3code#15746 * @BlankParticle made their first contribution in pingdotgg/t3code#15594 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261005.2676...v0.0.46-nightly.20261005.2689 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2689
## What's Changed * fix(prs): queue fast actions and close batches by dragging by @maria-rcks in pingdotgg/t3code#15851 * perf(prs): share concurrent github routing metadata probes by @maria-rcks in pingdotgg/t3code#15853 * fix(mobile): back from a finished subagent in the feed returns to its parent by @AKolenda in pingdotgg/t3code#15844 * fix(desktop): bound preview inspector retention and record renderer identity by @maria-rcks in pingdotgg/t3code#16032 * fix(web): show fast mode beside reasoning as text by @maria-rcks in pingdotgg/t3code#16069 * fix(mobile): make the routes list match the other settings rows by @juliusmarminge in pingdotgg/t3code#15958 * fix(threads): stop pull request watches when settling by @Bil0000 in pingdotgg/t3code#16095 * feat(contracts): clients tolerate union members they don't know yet by @juliusmarminge in pingdotgg/t3code#15951 * refactor(contracts): project icons decode forward-compatibly instead of encoding a fallback by @juliusmarminge in pingdotgg/t3code#16118 * Removed an unused helper from the Android push payload builder by @kridaydave in pingdotgg/t3code#16116 * perf(mobile): reduce shell cache encoding work by @juliusmarminge in pingdotgg/t3code#15096 * perf(mobile): defer audio recorder creation until dictation by @juliusmarminge in pingdotgg/t3code#15248 * feat(server): bump Antigravity ACP agent to 1.3.0 by @Droyder7 in pingdotgg/t3code#15746 * feat(acp): support local provider commands by @maria-rcks in pingdotgg/t3code#16021 * fix(server): honor submodule settings when creating worktrees by @BlankParticle in pingdotgg/t3code#15594 ## New Contributors * @Droyder7 made their first contribution in pingdotgg/t3code#15746 * @BlankParticle made their first contribution in pingdotgg/t3code#15594 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261005.2676...v0.0.46-nightly.20261005.2689 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261005.2689
Follow-up to #15068.
#15068 fixed the live subagent group card (
thread-subagent-group.tsx) to push the agent's thread so Android back returns to the parent. But that card only shows while agents are running. Once an agent finishes, the entry point is the "Subagent … finished" row in the thread work log (thread-work-log.tsx), which still callednavigate("Thread")— that reuses the currentThreadroute, drops the parent from the stack, and sends back straight to Home.This flips that one call to
StackActions.push, matching #15068, so opening a finished subagent from the feed and pressing back returns to the parent thread.Before / after (Pixel 9, Android 17)
Opening the finished "Scan Supabase backend" subagent, then pressing back — left is current behaviour, right is this PR:
Note: the "Open agents" sheet (
ThreadAgentsSheet.tsx) intentionally usesStackActions.replaceand is left as-is.Built with Claude Opus 5.5.