Repository navigation
Conversation
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| {/* An element, not bare text: bare text takes its line box from the control, which | ||
| inherits the row's size, so beside a text-sm title it sat below the other meta. */} | ||
| <span>{presentation.text}</span> | ||
| <span className="max-w-40 truncate">{presentation.text}</span> |
There was a problem hiding this comment.
🟡 Medium components/ThreadStatusIndicators.tsx:305
The badge text still expands the sidebar row instead of showing an ellipsis when it exceeds 10rem. Because this <span> is an inline child under display: contents, max-w-40 and truncate do not establish a box where those styles apply; make it inline-block (or block) before applying the width and truncation.
| <span className="max-w-40 truncate">{presentation.text}</span> | |
| <span className="inline-block max-w-40 truncate">{presentation.text}</span> |
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/web/src/components/ThreadStatusIndicators.tsx around line 305:
The badge text still expands the sidebar row instead of showing an ellipsis when it exceeds 10rem. Because this `<span>` is an inline child under `display: contents`, `max-w-40` and `truncate` do not establish a box where those styles apply; make it `inline-block` (or block) before applying the width and truncation.
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — This is a focused, tested UI bug fix that replaces ambiguous aggregate linked-PR counts with per-status summaries across existing web and mobile paths, without schema, infrastructure, security, or product-default changes. A Medium-severity unresolved layout finding indicates the web truncation may still be ineffective and remains a separate risk to address. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughUnrelated linked pull requests now display counts grouped by status instead of an aggregate state and total-only count. The shared resolver provides the summary, and web and mobile presentations show it with neutral styling. ChangesPer-status Pull Request Badges
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Mixed-status linked PRs display separate counts. No actionable merge-blocking issue was found in the selected change; normal checks can proceed. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected changes affect how linked pull-request statuses are displayed, rather than permissions or privileged operations. Link identity and interaction routing remain separate from the new summary. Risk is low, although an independent comparison with the previous implementation was unavailable. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
1 participant
A thread with three open and three closed PRs shows a green
+6, which looks like six open PRs. This affects the sidebar, composer toolbar, and mobile thread list.Show separate counts such as
3 open · 3 closedfor unrelated linked PRs. Shared counting distinguishes ready open PRs, drafts, closed PRs, merged PRs, and pending snapshots, and excludes dismissed links. The badge uses a neutral color, long summaries truncate within the row, and individual PRs and stacks retain their existing behavior. Desktop uses the shared web components.Fixes #15702. Alternative to #15724, which shows a neutral total. Choose one approach rather than merging both.
Validation: 115 focused tests passed across shared badge logic, web presentation/subscriptions, and mobile presentation. Targeted lint completed with pre-existing warnings; formatting and whitespace checks passed. An independent GPT-6-Astra reviewer at high reasoning found no correctness issues; an outdated sidebar comment noted during review was corrected. Full app typechecks were stopped after host memory/thread pressure prevented completion. Narrower single-threaded typechecks then passed for the shared counting logic, mobile presentation and tests, and web badge component and tests with their required ambient declarations. Browser/device verification and new before/after screenshots remain outstanding.
Implemented by GPT-6-Astra through the Codex harness.