Skip to content

test(server): skip the pathspec-magic filename test on Windows #15651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OhadC wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −28
Open

test(server): skip the pathspec-magic filename test on Windows #15651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6a886
test(server): skip the pathspec-magic filename test on Windows
OhadC Oct 4, 2026
213fbc3
Merge branch 'main' into skip-pathspec-test-on-windows
OhadC Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 30 additions & 28 deletions apps/server/src/vcs/GitVcsDriverCore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1566,36 +1566,38 @@ it.layer(layerTest)("GitVcsDriver core integration", (it) => {
}),
);

it.effect("keeps untracked filenames with pathspec magic in the review", () =>
Effect.gen(function* () {
const cwd = yield* makeTmpDir();
yield* initRepoWithCommit(cwd);
const driver = yield* GitVcsDriver.GitVcsDriver;
yield* writeTextFile(cwd, ":(exclude)after.ts", "literal pathspec contents\n");
yield* writeTextFile(cwd, "ordinary.ts", "ordinary contents\n");
const indexBefore = yield* git(cwd, ["ls-files", "--stage"]);
it.effect.skipIf(HostProcessPlatform.defaultValue() === "win32")(
"keeps untracked filenames with pathspec magic in the review",
() =>
Effect.gen(function* () {
const cwd = yield* makeTmpDir();
yield* initRepoWithCommit(cwd);
const driver = yield* GitVcsDriver.GitVcsDriver;
yield* writeTextFile(cwd, ":(exclude)after.ts", "literal pathspec contents\n");
yield* writeTextFile(cwd, "ordinary.ts", "ordinary contents\n");
const indexBefore = yield* git(cwd, ["ls-files", "--stage"]);

const preview = yield* driver.getReviewDiffPreview({ cwd, ignoreWhitespace: false });
const diff = preview.sources.find((source) => source.kind === "working-tree")?.diff ?? "";
const preview = yield* driver.getReviewDiffPreview({ cwd, ignoreWhitespace: false });
const diff = preview.sources.find((source) => source.kind === "working-tree")?.diff ?? "";

assert.include(diff, "+literal pathspec contents");
assert.include(diff, "+ordinary contents");
const scoped = yield* driver.getReviewDiffPreview({
cwd,
file: {
path: ":(exclude)after.ts",
previousPath: null,
sourceKind: "working-tree",
},
});
const scopedSource = scoped.sources.find((source) => source.kind === "working-tree")!;
assert.deepStrictEqual(scopedSource.files, [
{ path: ":(exclude)after.ts", previousPath: null, additions: 1, deletions: 0 },
]);
assert.include(scopedSource.diff, "+literal pathspec contents");
assert.notInclude(scopedSource.diff, "ordinary.ts");
assert.strictEqual(yield* git(cwd, ["ls-files", "--stage"]), indexBefore);
}),
assert.include(diff, "+literal pathspec contents");
assert.include(diff, "+ordinary contents");
const scoped = yield* driver.getReviewDiffPreview({
cwd,
file: {
path: ":(exclude)after.ts",
previousPath: null,
sourceKind: "working-tree",
},
});
const scopedSource = scoped.sources.find((source) => source.kind === "working-tree")!;
assert.deepStrictEqual(scopedSource.files, [
{ path: ":(exclude)after.ts", previousPath: null, additions: 1, deletions: 0 },
]);
assert.include(scopedSource.diff, "+literal pathspec contents");
assert.notInclude(scopedSource.diff, "ordinary.ts");
assert.strictEqual(yield* git(cwd, ["ls-files", "--stage"]), indexBefore);
}),
);

it.effect("detects an unstaged rename with edits without mutating a split index", () =>
Expand Down
Loading