Repository navigation
fix(server): skip native sessions during bulk import - #15634
maria-rcks wants to merge 3 commits into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 22 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This production bug fix changes bulk import from always attempting a session to conditionally suppressing the entire event and runtime write when another thread owns the native session. The ownership check is implemented in the shared transactional event sink, making this an automatic processing gate that warrants human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 2744869
Bulk import could publish a second thread for a Claude or Codex session T3 Code already owns, including archived and deleted originals. The v2 event sink now rechecks ownership in the same provider instance inside the publication transaction. Owned sessions create no history or runtime row and count as neither imported nor failed, so onboarding keeps the selected landing project without a false import warning. Ordinary imports and retries recover resume metadata without replaying history.
Existing duplicates and cross-environment deduplication remain outside this fix.
Verified on Blacksmith: importer tests (failed-write retry plus active, deleted, other-instance, and unowned native sessions for Codex and Claude against real SQLite projections) and the welcome-wizard tests pass; server typecheck and scoped lint pass. Real provider transcript import through the client is unverified.
Closes #10933
Written by claude-opus-5-5 via Claude Code in T3 Code