fix(server): expand home-relative media paths

[maria-rcks]

home-relative media links such as [repro.mp4](~/Downloads/repro.mp4) reached the server unchanged for /var/home workspaces and were looked up under <project>/~/Downloads. expand media paths with the environment's actual home before workspace-relative resolution, using the existing home-expansion helper.

• blacksmith: reproduced the original missing-file error before the fix; 147 tests passed across asset access, home expansion, markdown links, terminal links, and shared media resolution after the fix. the regression resolves signed URLs and reads the media response for workspaces inside and outside home, and without workspace context.
• blacksmith: scoped formatting and lint passed with one warning on unchanged code; server typecheck passed. absolute/relative media paths, workspace containment, and existing symlink protection are covered by the existing asset tests.
• unverified: real provider/client playback on a Fedora /var/home account and native desktop/mobile behavior. the parent-owned shared preview currently times out; runtime evidence is pending.

Closes #15601

model: gpt-6.1-sol (xhigh) · harness: codex through t3 code

[macroscopeapp]

Approvability

Verdict: Approved at 9432428

Macroscope's review found this PR approvable — This is a narrowly scoped server bug fix that expands home-relative media paths into the existing validated absolute-file flow. Regression coverage exercises the supported path formats and workspace contexts without changing schemas, defaults, or security-sensitive configuration.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5f2b7d61-f58b-4c62-80e7-5e45ba225985

📥 Commits

Reviewing files that changed from the base of the PR and between 4ee6bfd and 3ce5cfe.

📒 Files selected for processing (2)

• apps/server/src/assets/AssetAccess.test.ts
• apps/server/src/assets/AssetAccess.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

Media-file issuance now expands home-directory syntax before path resolution. Tests cover tilde paths with both slash styles and workspaces inside, outside, or absent.

Changes

Media path resolution

Layer / File(s)	Summary
Expand and validate media paths apps/server/src/assets/AssetAccess.ts, apps/server/src/assets/AssetAccess.test.ts	Media-file issuance expands home-relative paths before checking whether they are absolute. Tests verify URL resolution and returned file bytes for both slash styles and different workspace configurations.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 3ce5c

Home-relative media links appear ready to merge after normal checks. Playback on the reported Fedora desktop remains unverified, but no actionable failure is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 3ce5c

The change affects 1 system.

Changed systems: apps/server

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — apps/server (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in apps/server/src/assets/AssetAccess.test.ts: Adds the node:os import for the test’s home-directory mock.
• observed — Modified behavior in apps/server/src/assets/AssetAccess.test.ts: Mocks node:os while preserving its actual exports, and wraps homedir in a spy.
• observed — Modified behavior in apps/server/src/assets/AssetAccess.test.ts: Adds a test for home-relative media paths in both slash styles, with a workspace inside the home directory, outside it, or absent. It sets the mocked home directory, then checks that each issued URL resolves to the canonical MP4 file and that serving it returns the expected bytes; the mock is restored in a finally block.
• observed — Modified behavior in apps/server/src/assets/AssetAccess.ts: Adds the expandHomePathWith import used to expand media paths.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Issue #15601 requires ~/... media links to resolve under the environment home and load the existing file. issueAssetUrl now applies expandHomePathWith before workspace-relative resolution. The r…
Out of Scope Changes check	✅ Passed	The changes are limited to home-expanding media paths in AssetAccess.ts and a regression test in AssetAccess.test.ts. Both changes directly support issue #15601. No unrelated changes appear in the…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Title check	✅ Passed	The title clearly and concisely describes the main change: expanding home-relative media paths on the server.
Description check	✅ Passed	The description explains the problem, the fix, and focused verification results, and it links the related issue. It does not include explicit template headings or document maintainer approval or why t…

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

Dismissing prior approval to re-evaluate 9432428