Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR narrowly fixes snooze timestamp baselines on both the server and optimistic client state, with targeted regression coverage. Its runtime impact is limited to correctly resetting snooze timestamps when a user explicitly re-snoozes a thread. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14298
What changed
thread.snoozein the decider no longer keeps the originalsnoozedAtwhen re-snoozing to the same wake time. Every explicit snooze stampssnoozedAtandupdatedAtfresh. The optimistic twin inthreadCommands.tsmatches. Net deletion plus test updates.Why
A re-snooze to the same wake time kept the original
snoozedAt. The raised-hand check compares session and turn timestamps against it, so a failure newer than the first snooze kept the thread in the inbox forever. Repeating the same preset is the normal case since presets resolve to fixed clock times. An explicit snooze means the user saw the thread, so it must reset the baseline. True retries still dedupe bycommandIdreceipts.Verification
vp test run decider.snoozed.test.tsgives 10 passedvp test run threadCommands.test.ts -t "snooz"gives 6 passed, 13 skippedvp linton all four touched files gives cleantsc --noEmitinapps/serverandpackages/client-runtimegives exit 0fallow audit --base main --briefgives exit 0, no findings on changed linesNo screenshots. No UI change, only the snooze timestamp baseline behind inbox classification.
Flow
flowchart TD A[thread wakes as Failed] --> B[user re-snoozes same preset] B --> C{snoozedAt?} C -- before: original kept --> D[raised-hand check still true, thread stuck in inbox] C -- after: stamped now --> E[baseline resets, thread leaves inbox until wake time]Built with muse-spark-1.3 via pi coding agent.