fix(server): drop stale Grok models missing from a successful refresh

apps/server/src/provider/Layers/ProviderRegistry.test.ts

@@ -922,6 +922,120 @@ it.layer(Layer.mergeAll(TestNodeServices, ServerSettingsModule.layerTest(), Test
         assert.deepStrictEqual(afterFailure.models, [authoritativeProvider.models[0]!]);
       });
 
+      it("drops stale Grok models missing from a successful refresh", () => {
+        const previousProvider = {
+          instanceId: ProviderInstanceId.make("grok"),
+          driver: ProviderDriverKind.make("grok"),
+          status: "ready",
+          enabled: true,
+          installed: true,
+          auth: { status: "authenticated" },
+          checkedAt: "2026-09-30T00:00:00.000Z",
+          version: "1.0.44",
+          models: [
+            {
+              slug: "grok-4.7",
+              name: "Grok 4.7",
+              isCustom: false,
+              capabilities: null,
+            },
+            {
+              slug: "codexhub-removed-model",
+              name: "Removed gateway model",
+              isCustom: false,
+              capabilities: null,
+            },
+          ],
+          slashCommands: [],
+          skills: [],
+        } as const satisfies ServerProvider;
+        const refreshedProvider = {
+          ...previousProvider,
+          checkedAt: "2026-09-30T00:01:00.000Z",
+          models: [
+            {
+              slug: "grok-4.7",
+              name: "Grok 4.7",
+              isCustom: false,
+              capabilities: null,
+            },
+          ],
+        } satisfies ServerProvider;
+
+        assert.deepStrictEqual(mergeProviderSnapshot(previousProvider, refreshedProvider).models, [
+          ...refreshedProvider.models,
+        ]);
+      });
+
+      it("retains stale Grok models when a refresh fails", () => {
+        const previousProvider = {
+          instanceId: ProviderInstanceId.make("grok"),
+          driver: ProviderDriverKind.make("grok"),
+          status: "ready",
+          enabled: true,
+          installed: true,
+          auth: { status: "authenticated" },
+          checkedAt: "2026-09-30T00:00:00.000Z",
+          version: "1.0.44",
+          models: [
+            {
+              slug: "grok-4.7",
+              name: "Grok 4.7",
+              isCustom: false,
+              capabilities: null,
+            },
+          ],
+          slashCommands: [],
+          skills: [],
+        } as const satisfies ServerProvider;
+        const refreshedProvider = {
+          ...previousProvider,
+          status: "error",
+          auth: { status: "unknown" },
+          checkedAt: "2026-09-30T00:01:00.000Z",
+          models: [],
+          message: "Failed to refresh Grok models.",
+        } satisfies ServerProvider;
+
+        assert.deepStrictEqual(mergeProviderSnapshot(previousProvider, refreshedProvider).models, [
+          ...previousProvider.models,
+        ]);
+      });
+
+      it("retains stale Grok models when ACP discovery fails with a warning", () => {
+        const previousProvider = {
+          instanceId: ProviderInstanceId.make("grok"),
+          driver: ProviderDriverKind.make("grok"),
+          status: "ready",
+          enabled: true,
+          installed: true,
+          auth: { status: "authenticated" },
+          checkedAt: "2026-09-30T00:00:00.000Z",
+          version: "1.0.44",
+          models: [
+            {
+              slug: "grok-4.7",
+              name: "Grok 4.7",
+              isCustom: false,
+              capabilities: null,
+            },
+          ],
+          slashCommands: [],
+          skills: [],
+        } as const satisfies ServerProvider;
+        const refreshedProvider = {
+          ...previousProvider,
+          status: "warning",
+          checkedAt: "2026-09-30T00:01:00.000Z",
+          models: [],
+          message: "Grok CLI is installed but ACP initialize failed.",
+        } satisfies ServerProvider;
+
+        assert.deepStrictEqual(mergeProviderSnapshot(previousProvider, refreshedProvider).models, [
+          ...previousProvider.models,
+        ]);
+      });
+
       describe("Codex model inventories", () => {
         const cachedProvider = {
           instanceId: ProviderInstanceId.make("codex-personal"),

apps/server/src/provider/Layers/ProviderRegistry.ts

@@ -105,7 +105,13 @@ export function upsertProviderWorkspaceSnapshot(
 const shouldRetainMissingProviderModels = (provider: ServerProvider): boolean => {
   const isAntigravity = provider.driver === ProviderDriverKind.make("antigravity");
   const isCodex = provider.driver === ProviderDriverKind.make("codex");
-  if (!isAntigravity && !isCodex && provider.driver !== ProviderDriverKind.make("opencode")) {
+  const isGrok = provider.driver === ProviderDriverKind.make("grok");
+  if (
+    !isAntigravity &&
+    !isCodex &&
+    !isGrok &&
+    provider.driver !== ProviderDriverKind.make("opencode")
+  ) {
     return true;
   }
 
@@ -123,8 +129,16 @@ const shouldRetainMissingProviderModels = (provider: ServerProvider): boolean =>
   const isPendingInitialProbe =
     provider.enabled && !provider.installed && provider.status === "warning";
   const didInstalledProviderProbeFail = provider.installed && provider.status === "error";
+  // Grok reports installed warning states while discovery is incomplete: the
+  // initial availability snapshot and ACP initialize failures both carry
+  // partial inventories that must not erase the cached models.
+  const didInstalledGrokProbeRemainIncomplete =
+    isGrok && provider.installed && provider.status === "warning";
   return (
-    isPendingAntigravityAuthentication || isPendingInitialProbe || didInstalledProviderProbeFail
+    isPendingAntigravityAuthentication ||
+    isPendingInitialProbe ||
+    didInstalledProviderProbeFail ||
+    didInstalledGrokProbeRemainIncomplete
   );
 };