Repository navigation
feat(marketing): translate the homepage into five languages - #14192
bmdavis419 wants to merge 2 commits into
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| .harness-grid { | ||
| grid-template-columns: 1fr 1fr; | ||
| } |
There was a problem hiding this comment.
🟡 Medium styles/homepage.css:1044
At a 320px viewport, unbreakable .harness-tag values such as antigravity overflow their two-column cells and escape the grid. The cells have only about 58px for text after the icon, gap, padding, and gutters; constrain the tag text with ellipsis (or switch to a single-column layout) at narrow widths.
.harness-grid {
grid-template-columns: 1fr 1fr;
}
+ .harness-tag {
+ overflow: hidden;
+ text-overflow: ellipsis;
+ white-space: nowrap;
+ }🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/marketing/src/styles/homepage.css around lines 1044-1046:
At a 320px viewport, unbreakable `.harness-tag` values such as `antigravity` overflow their two-column cells and escape the grid. The cells have only about 58px for text after the icon, gap, padding, and gutters; constrain the tag text with ellipsis (or switch to a single-column layout) at narrow widths.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR adds a substantial multilingual marketing feature with new routes, translation infrastructure, a React homepage migration, and shared layout changes affecting existing pages. An unresolved medium-severity responsive-layout issue also remains in the new homepage styling. Not approved because:
Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (27)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe marketing site now renders a React-based homepage with English, Spanish, Brazilian Portuguese, German, Japanese, and Simplified Chinese content. It adds localized routes and site metadata, translation catalogs and tooling, and platform-aware download and motion initialization. ChangesLocalized Marketing Homepage
Workspace Build Policy
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant LocaleIndex as [locale] index.astro
participant HomePage as HomePage.astro
participant I18n as i18n.ts
participant Homepage as Homepage.tsx
participant Layout as Layout.astro
LocaleIndex->>HomePage: Pass locale prop
HomePage->>I18n: Load locale strings and homepage translations
I18n-->>HomePage: Return localized strings and translation catalog
HomePage->>Homepage: Pass locale, translations, and screenshot
HomePage->>Layout: Pass locale and localizedHome
Merge Risk: ⚪ Minimal · up to The homepage now renders statically in six languages, with localized navigation, metadata, and platform-aware download links. No concrete defects were identified, and the change appears ready to merge after normal CI checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new language routes use fixed locales and bundled translations rather than a new request-time translation service. A narrowly scoped exception to the dependency release-age policy merits review, but no exploitable issue was established. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (22 skipped: 22 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
Note This comment is posted by Julius' dot Closing for missing prior scope approval. At The reported build/catalog checks and the supplied English, Spanish and Chinese screenshots are useful verification. They do not replace prior approval. Please agree with maintainers on the languages, homepage scope and translation workflow, link that explicit decision, and request reconsideration. |
2 participants
The homepage was English-only. It now supports Spanish, Brazilian Portuguese, German, Japanese, and Simplified Chinese through General Translation, with English retained at
/.Homepage.tsxuses GT's React provider, translation components, and hooks for homepage copy and testimonials. Astro renders committed catalogs to static HTML without React hydration or translation credentials at build/runtime.[locale]/index.astroandlib/i18n.tsgenerate the five localized routes.Layout.astroadds a language selector, localized metadata/accessibility labels, canonical URLs, and hreflang links.gt.config.json, catalogs, and development instructions support future translation updates.Validation: marketing typecheck and production build passed; targeted lint passed; both homepage motion tests passed; GT validated all 67 entries. Checked all six built pages for catalog coverage, metadata, locale links, platform labels, and absence of hydration. Browser-checked language switching, download detection, desktop rendering, and all five mobile translations.
Before (desktop):
After (Spanish desktop):
After (Simplified Chinese mobile):
Model: GPT-6 · Harness: Codex.
Summary by CodeRabbit