Skip to content

fix(server): allow handoff after a provider session detaches - #13882

Merged
Yash-Singh1 merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/fix-detached-provider-handoff
Sep 26, 2026
Merged

Yash-Singh1 merged 1 commit into
t3code/codex-turn-mappingfrom
t3code/fix-detached-provider-handoff

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

What Changed

Allow a completed thread to switch providers when its session has detached but its active provider thread still has a native reference.

Why

Detached sessions no longer appear in the thread projection. That hid the provider thread needed to hand off on the next turn. Check the active provider thread's native reference when deciding whether handoff is supported.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 26, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 5ffe144

Macroscope's review found this PR approvable — This is a small, well-tested bug fix that exposes an existing provider-handoff path after a session detaches, while preserving active-run and missing-native-reference safeguards. It does not alter schemas, defaults, infrastructure, or static-analysis settings.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.1 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 1 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.8 KiB — 29.3 KiB ✅
Claude Live turn messages — 2 — 8 ✅

Baseline: unavailable · PR result: 5ffe144 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@Yash-Singh1
Yash-Singh1 merged commit 00e1a9c into t3code/codex-turn-mapping Sep 26, 2026
24 checks passed
@Yash-Singh1
Yash-Singh1 deleted the t3code/fix-detached-provider-handoff branch September 26, 2026 22:05
@Yash-Singh1
Yash-Singh1 restored the t3code/fix-detached-provider-handoff branch September 26, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant