Skip to content

fix(mobile): show the Android code block copy icon - #13580

Closed
macodev00 wants to merge 1 commit into
pingdotgg:mainfrom
macodev00:cursor/android-codeblock-copy-icon-e65f
Closed

macodev00 wants to merge 1 commit into
pingdotgg:mainfrom
macodev00:cursor/android-codeblock-copy-icon-e65f

Conversation

@macodev00

@macodev00 macodev00 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

The fenced code block copy button in the native markdown renderer now passes platform symbol names (doc.on.doc / content_copy, and checkmark / check after a copy) instead of an iOS-only SF Symbol string.

Why

On Android, expo-symbols treats a string name as an SF Symbol, resolves it to nothing, and draws no glyph. The header button stayed an empty rounded square even though tapping still copied. The same names already work on the app copy button. iOS still uses the SF Symbol.

Fixes #13376

UI Changes

Before: the code block header copy control is an empty rounded square (screenshot on the issue). After: the copy icon shows, and the check icon shows once the text is copied. No motion or timing change.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Summary by CodeRabbit

  • Bug Fixes
    • Updated the copy button’s icons to display appropriately on Android while retaining the existing iOS symbols.

expo-symbols treats a string name as an iOS SF Symbol, so the fenced
code block copy button drew an empty square on Android. Pass the same
platform names the other copy buttons use.
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 25, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bc568c3

Macroscope's review found this PR approvable — This single-file fix supplies Android Material icon names while preserving the existing iOS symbols and all copy-button behavior. Its runtime impact is limited to restoring the missing visual glyphs, with no product-default, schema, security, or infrastructure changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d3c930bc-e80d-415e-9919-79ccf72a6186

📥 Commits

Reviewing files that changed from the base of the PR and between c13f7d9 and bc568c3.

📒 Files selected for processing (1)
  • apps/mobile/modules/t3-markdown-text/src/CopyTextButton.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The code block copy button now provides Android-specific symbol names to SymbolView. iOS retains its existing SF Symbol names.

Changes

Copy button symbols

Layer / File(s) Summary
Platform-specific copy symbols
apps/mobile/modules/t3-markdown-text/src/CopyTextButton.tsx
SymbolView receives check for the copied state and content_copy otherwise on Android. iOS retains its SF Symbol names.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to bc568

The code-block copy button uses Android-compatible icons while retaining its iOS symbols. No material merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Android code block copy icon fix and matches the primary change.
Description check ✅ Passed The description includes the required What Changed, Why, UI Changes, and Checklist sections. It explains the Android issue, the platform-specific symbol names, and the expected UI result.
Linked Issues check ✅ Passed Issue #13376 requires a visible copy icon on Android for fenced code blocks. In CopyTextButton.tsx, the copied state now uses { ios: "checkmark", android: "check" }, and the normal state uses `{ i…
Out of Scope Changes check ✅ Passed The pull request changes only the symbol names used by the native Markdown code-block copy button. The change directly supports issue #13376 and preserves the existing copied-state behavior, size, tin…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member

Note

This comment is posted by Julius' dot

#13376 shows the missing Android icon, but this PR has no after image or recorded check that the copy and checkmark glyphs render. I'm closing it under the verification requirement. Attach both fixed states from Android, record the device/build and result, and request reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Mobile] Android code block copy button is missing its icon

2 participants