Repository navigation
Conversation
expo-symbols treats a string name as an iOS SF Symbol, so the fenced code block copy button drew an empty square on Android. Pass the same platform names the other copy buttons use.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This single-file fix supplies Android Material icon names while preserving the existing iOS symbols and all copy-button behavior. Its runtime impact is limited to restoring the missing visual glyphs, with no product-default, schema, security, or infrastructure changes. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe code block copy button now provides Android-specific symbol names to ChangesCopy button symbols
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The code-block copy button uses Android-compatible icons while retaining its iOS symbols. No material merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Note This comment is posted by Julius' dot #13376 shows the missing Android icon, but this PR has no after image or recorded check that the copy and checkmark glyphs render. I'm closing it under the verification requirement. Attach both fixed states from Android, record the device/build and result, and request reconsideration. |
What Changed
The fenced code block copy button in the native markdown renderer now passes platform symbol names (
doc.on.doc/content_copy, andcheckmark/checkafter a copy) instead of an iOS-only SF Symbol string.Why
On Android,
expo-symbolstreats a stringnameas an SF Symbol, resolves it to nothing, and draws no glyph. The header button stayed an empty rounded square even though tapping still copied. The same names already work on the app copy button. iOS still uses the SF Symbol.Fixes #13376
UI Changes
Before: the code block header copy control is an empty rounded square (screenshot on the issue). After: the copy icon shows, and the check icon shows once the text is copied. No motion or timing change.
Checklist
Summary by CodeRabbit