Skip to content

fix(mobile): lift working control above question overlay - #13297

Merged
juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
fix-mobile-question-modal-overlay
Sep 23, 2026
Merged

juliusmarminge merged 1 commit into
t3code/codex-turn-mappingfrom
fix-mobile-question-modal-overlay

Conversation

@gabrielelpidio

@gabrielelpidio gabrielelpidio commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What Changed

  • Lift the floating working control as the question card expands.
  • Pass the question card's animated coverage to the control and apply it as a vertical translation.

Why

The floating working control could render over the expanded question overlay. Tying its position to the overlay's animated coverage keeps the control visible above the card throughout the expansion.

UI Changes

The mobile thread view now keeps the floating working control above the expanded question overlay.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Summary by CodeRabbit

  • New Features

    • Added mobile settings for scheduled tasks, follow-up behavior, provider accounts, branch naming, and usage-limit recovery.
    • Added thread queue and agent views, queued-message editing, thread context links, and richer activity details.
    • Expanded MCP tools for managing threads, projects, attachments, environments, and worktrees.
    • Added desktop profile migration that preserves Windows sign-in data.
  • Improvements

    • Improved thread status and provider visibility, composer controls, and mobile model-option persistence.
    • Updated mobile production builds to submit to the v2 testing tracks by default.
    • Increased CORS support for browser API requests.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 23, 2026
@gabrielelpidio
gabrielelpidio force-pushed the fix-mobile-question-modal-overlay branch from c73439b to bb74ed3 Compare September 23, 2026 19:36
@gabrielelpidio
gabrielelpidio changed the base branch from main to t3code/codex-turn-mapping September 23, 2026 19:36
@github-actions github-actions Bot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 23, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at bb74ed3

Macroscope's review found this PR approvable — This is a narrowly scoped mobile UI correction that synchronizes an existing floating control with the question-card animation on iOS. It preserves existing behavior elsewhere and introduces no schema, configuration, security, or static-analysis changes.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 4.9 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.4 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 4.9 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.7 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 20.7 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: bb74ed3 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 106.1 KiB
  • Claude decoded thread snapshot: 106.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@gabrielelpidio

Copy link
Copy Markdown
Contributor Author

Updated iOS simulator screenshot: the floating device button sits above the question card with the same 8-point gap as the composer.

Floating device button above the question card with an 8-point gap

@juliusmarminge
juliusmarminge merged commit c8f18cf into t3code/codex-turn-mapping Sep 23, 2026
25 of 27 checks passed
@juliusmarminge
juliusmarminge deleted the fix-mobile-question-modal-overlay branch September 23, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants