Skip to content

chore(lint): keep mobile theme escape-hatch allowlist honest #13146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Sep 23, 2026
Merged

chore(lint): keep mobile theme escape-hatch allowlist honest #13146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea3916c
chore(lint): keep mobile theme escape-hatch allowlist honest
juliusmarminge Sep 22, 2026
f27a865
refactor(mobile): style appearance code preview with semantic classes
juliusmarminge Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,6 @@ export function ThreadFilesTreeScreen(props: ThreadFilesRouteScreenProps) {
const { fileInspector, layout, showAuxiliaryPane } = useAdaptiveWorkspaceLayout();
const [searchQuery, setSearchQuery] = useState("");
const { themeAppearance: highlightTheme } = useAppearancePreferences();
const headerColor = useUniwindTheme()["--color-header"];
const { cwd, environmentId, projectName, selectedThread, threadId } = useThreadFilesWorkspace(
props.route.params,
);
Expand Down Expand Up @@ -554,13 +553,7 @@ export function ThreadFilesTreeScreen(props: ThreadFilesRouteScreenProps) {
</>
);

return Platform.OS === "android" ? (
<View className="flex-1" style={{ backgroundColor: headerColor }}>
{content}
</View>
) : (
content
);
return Platform.OS === "android" ? <View className="flex-1 bg-header">{content}</View> : content;
}

export function ThreadFileScreen(props: ThreadFileRouteScreenProps) {
Expand Down
9 changes: 2 additions & 7 deletions apps/mobile/src/features/settings/appearance/components/AppearancePreviews.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
resolveMarkdownFontSizes,
resolveMobileCodeSurface,
} from "../../../../lib/appearancePreferences";
import { useUniwindTheme } from "../../../../lib/useUniwindTheme";
import { getMobileTerminalTheme } from "../../../terminal/terminalTheme";
import { useAppearancePreferences } from "../AppearancePreferencesProvider";

Expand Down Expand Up @@ -138,16 +137,12 @@ export function CodeAppearancePreview(props: {
readonly wordBreak: boolean;
}) {
const surface = resolveMobileCodeSurface(props.fontSize);
const theme = useUniwindTheme();
const lineNumberColor = theme["--color-icon-subtle"];
const keywordColor = theme["--color-md-link"];

const lineNumber = (line: CodePreviewLine, index: number) => (
<Text
className="text-right"
className="text-right text-icon-subtle"
key={line.id}
style={{
color: lineNumberColor,
fontFamily: CODE_FONT_FAMILY,
fontSize: surface.lineNumberFontSize,
lineHeight: surface.rowHeight,
Expand All @@ -172,8 +167,8 @@ export function CodeAppearancePreview(props: {
{line.tokens.map((token) => (
<Text
key={token.text}
className={token.keyword ? "text-md-link" : undefined}
style={{
color: token.keyword ? keywordColor : undefined,
fontFamily: CODE_FONT_FAMILY,
fontSize: surface.fontSize,
lineHeight: surface.rowHeight,
Expand Down
2 changes: 0 additions & 2 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,15 +201,13 @@ export default defineConfig({
"apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx",
"apps/mobile/src/features/files/FileMarkdownPreview.tsx",
"apps/mobile/src/features/files/SourceFileSurface.tsx",
"apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx",
"apps/mobile/src/features/files/AttachmentFileScreen.tsx",
"apps/mobile/src/features/files/ThreadFilesRouteScreen.tsx",
"apps/mobile/src/features/files/thread-file-navigator-pane.tsx",
"apps/mobile/src/features/home/HomeHeader.tsx",
"apps/mobile/src/features/review/ReviewSheet.tsx",
"apps/mobile/src/features/review/useNativeReviewDiffBridge.ts",
"apps/mobile/src/features/settings/SettingsEnvironmentsRouteScreen.tsx",
"apps/mobile/src/features/settings/appearance/components/AppearancePreviews.tsx",
"apps/mobile/src/features/threads/GitActionProgressOverlay.tsx",
"apps/mobile/src/features/threads/NewTaskDraftScreen.tsx",
"apps/mobile/src/features/threads/ThreadComposer.tsx",
Expand Down
Loading