Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused reduced-motion accessibility fix that preserves existing destinations and interaction behavior while removing unnecessary animated travel across established web and mobile scroll paths. The production logic is small and supported by targeted preference and fallback tests, with the larger diff primarily consisting of tests and documentation. You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughWeb and mobile scrolling and reveal actions now account for reduced-motion preferences. The web changes use a shared preference helper, including a fallback for unavailable browser APIs. Mobile thread scrolling checks the device accessibility preference. ChangesReduced-motion behavior
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Programmatic scrolling now follows the reduced-motion preference on web and mobile, with instant movement when the preference cannot be read. No merge-blocking issue was found. Native mobile behavior was verified only by tests. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 13 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Dismissing prior approval to re-evaluate d92242b
|
Note This comment is posted by Julius' dot Closing for missing current motion verification. At The focused preference/fallback tests are useful. The verification requirement also calls for before/after UI evidence and a short recording for motion or timing changes. Please provide current web/Electron and native before/after proof covering a live preference change, the affected scroll/reveal actions and mobile keyboard/scroll timing, while showing preserved destinations and focus. Identify the tested commit and results, then request reconsideration. |
|
Following up on the closure for missing current motion verification: the bug is now filed as #15953, with live before/after proof on main
This branch's fallback-only changes (tabs, settings search, citations) are dropped, because those paths already honor the preference on main. Android and the macOS desktop app with the real system setting are not verified; both PRs say so. |
What Changed
Programmatic scrolling now reads the current reduced-motion preference when the action runs. Theme token reveal, timeline minimap and send anchors, scroll-to-bottom, keyboard page steps, tabs, settings navigation and citation reveal share the web behavior; native message-to-end actions query the device preference. Missing or unavailable preference APIs select instant movement.
Scroll destinations, focus, selection, direct manipulation, held scrolling and keyboard dismissal retain their existing behavior. The contribution includes the cross-entry-point guidance in #12660, whose documentation commit is still part of this branch.
Verification
38969148toolchain. A prospective merge onto main35be904fis clean and preserves the exact contribution; that newer Vite toolchain was not tested here.Historical evidence from September 20 below predates the current repair and integration. It used an isolated proof app with
matchMediastubbed to reduced motion, comparing based6f291303with the then-current branch. It demonstrates that earlier PageDown scenario only; it does not verify the current revision or a native client.Implementation and readiness repair: GPT-6 Astra using Codex in T3 Code. Independent review: GPT-6.1 Sol using Codex in T3 Code.