Repository navigation
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR makes a focused web UI adjustment that adds visibility- and reduced-motion-aware pulsing only to explicitly selected running worker icons. It does not alter data contracts, workflows, product configuration defaults, or static-analysis settings. You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
from
September 21, 2026 03:05
61a3501 to
619623f
Compare
saphid
force-pushed
the
agent/web-v2-lineage-breath
branch
from
September 21, 2026 03:43
75081e6 to
d814253
Compare
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
8 times, most recently
from
September 24, 2026 04:06
1bd44f2 to
3b9c885
Compare
saphid
force-pushed
the
agent/web-v2-lineage-breath
branch
from
September 24, 2026 12:21
d814253 to
6f299d2
Compare
macroscopeapp
Bot
dismissed
their stale review
September 24, 2026 12:21
Dismissing prior approval to re-evaluate 6f299d2
Contributor
|
Macroscope has since reviewed this pull request. An earlier review was skipped by a cost limit; a review has now completed, so that notice no longer applies. |
saphid
force-pushed
the
agent/web-v2-lineage-breath
branch
from
September 24, 2026 12:25
6f299d2 to
3ffc159
Compare
juliusmarminge
force-pushed
the
t3code/codex-turn-mapping
branch
3 times, most recently
from
September 25, 2026 05:55
fe4f6ad to
87c67bd
Compare
saphid
force-pushed
the
agent/web-v2-lineage-breath
branch
from
September 25, 2026 07:36
3ffc159 to
ec2ae76
Compare
The base lint now rejects arbitrary Tailwind values, so the pulse uses a visible-animate-status-pulse utility beside visible-animate-spin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
saphid
force-pushed
the
agent/web-v2-lineage-breath
branch
from
September 27, 2026 23:37
ec2ae76 to
4b0eb3e
Compare
macroscopeapp
Bot
dismissed
their stale review
September 27, 2026 23:37
Dismissing prior approval to re-evaluate 4b0eb3e
Member
|
Superseded by #14412 (steady status labels instead of pulsing icons). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Running V2 worker icons now breathe in Lineage and their timeline links. Waiting, pending and finished workers stay still, as do parent and fork relationship icons.
Why
The static blue badge made a running worker look the same as one waiting for input. Reuse the existing two-second stepped opacity pulse and shared visibility observer. Motion stops off-screen or in hidden tabs, and reduced-motion preferences disable it.
The change is in the web UI shared with desktop. Provider adapters, wire contracts and mobile are unchanged.
Verification
ThreadRelationshipsControl.test.tsx,ThreadRelationshipsControl.agents.test.tsxandvisibleAnimation.test.tswithvp test run.vp lintandvp fmt --checkpassed for all three changed files.vp run --filter @t3tools/web typecheckpassed.UI Changes
Disposable synthetic lineage data, dark theme, 1200 × 900 CSS-pixel viewport. Base
a74e16065bf, candidate75081e6bd6f. These approximately six-second GIFs come from actual Chrome recordings with capture timestamps and no speed change. The baseline scene is static. The recordings predate a history-only rebase onto640dd532493; the three changed components, visibility helper and stylesheet are byte-identical at the current headd814253c650. Browser verification covers the shared web UI; no native desktop or mobile run was performed.The screenshots look identical because the candidate was captured during the pulse's full-opacity phase. The GIFs and videos show the motion.
Before: running workers have static icons.
Before recording · Before screenshot
After: only the three running worker icons breathe.
After recording · After screenshot
Port note (2026-09-24)
Ported onto upstream OV2
t3code/codex-turn-mappingat692ad0a8fdas one commit (3ffc15958d). Upstream now renders timeline subagent links withSubagentAvatarinstead ofThreadRelationshipIcon, so the same pulse (stepped opacity, visibility-gated,motion-safe) is applied toSubagentAvataronly from the timeline link; overlapped avatar stacks stay still. The evidence below was captured on the earlier rehearsal base, before this port, and the timeline avatar now looks different upstream.Checklist
Implemented by GPT-6 Astra in Codex. Reviewed by Fable 5.1 through T3 Code.