Skip to content

feat(settings): port PR-aware inactivity settlement to orchestration v2 - #12788

Closed
tris203 wants to merge 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
tris203:t3code/port-codex-turn-mapping-change
Closed

tris203 wants to merge 1 commit into
pingdotgg:t3code/codex-turn-mappingfrom
tris203:t3code/port-codex-turn-mapping-change

Conversation

@tris203

@tris203 tris203 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Reopens #12258 against t3code/codex-turn-mapping. Inactive exploratory threads should still settle automatically while users can keep PR-linked work active by choosing Threads without a PR. The other choices remain All threads and Off; defaults and independent merge/close rules are preserved.

The new base replaces the original settlement reactor with the V2 settlement service, so the earlier implementation cannot be carried over unchanged. This port applies the exclusion to V2's projection-backed decisions and includes scope in the settings key so environment and project changes trigger an immediate sweep. It retains the web/desktop and mobile controls, project overrides, shared settings sync, and capability filtering for older servers.

Validation: 316 focused tests passed, including V2 settlement/projection coverage, contracts, shared settings, and web/mobile scoped writes. Server, web, mobile, contracts, and client-runtime typechecks passed. Targeted lint passed with existing warnings; formatting and diff checks passed. An isolated dev server was provided for manual testing; no automated browser or simulator verification was performed.

UI reference from #12258 (the same controls are carried forward; this is not a new screenshot of the V2 build):

Inactivity settlement controls from the original PR

Model: GPT-6. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 20, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a defaulted inactivity-settlement scope and coordinates new production behavior across orchestration, settings contracts, project overrides, shared synchronization, and web/mobile controls. The cross-cutting runtime impact and product-default change require human review.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 2 times, most recently from a1f8051 to 0337dd6 Compare September 21, 2026 05:40
@tris203
tris203 force-pushed the t3code/port-codex-turn-mapping-change branch 2 times, most recently from 0c2096f to 255a771 Compare September 21, 2026 21:23
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 4 times, most recently from d2675dc to 9cbaf77 Compare September 23, 2026 07:35
@tris203
tris203 force-pushed the t3code/port-codex-turn-mapping-change branch from 255a771 to 831eb3f Compare September 23, 2026 11:30
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 3 times, most recently from 1bd44f2 to 3b9c885 Compare September 24, 2026 04:06
@tris203
tris203 force-pushed the t3code/port-codex-turn-mapping-change branch from 831eb3f to df75b73 Compare September 24, 2026 21:07
@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch 3 times, most recently from fe4f6ad to 87c67bd Compare September 25, 2026 05:55
@tris203
tris203 force-pushed the t3code/port-codex-turn-mapping-change branch from df75b73 to 69ca477 Compare September 25, 2026 06:56
@tris203
tris203 force-pushed the t3code/port-codex-turn-mapping-change branch from 69ca477 to 86ac45f Compare September 29, 2026 06:43

Copy link
Copy Markdown
Member

Note

This comment is posted by Julius' dot

Closing for incomplete UI evidence. At 86ac45f, the inactivity switch becomes an Off / All threads / Threads without a PR selector on web and mobile. The linked image from #12258 shows the resulting web dropdown only; neither PR supplies a before view or the changed native control. The focused tests and explicit V2-port limitations are useful, but do not complete the required before/after comparison.

Verification requires clear before/after screenshots for UI changes. Please add that comparison for the affected web and native controls, identify the tested build/environment, and request reconsideration. The PR-scoped inactivity option can be assessed as configuration of existing settlement behavior; this closure is for the missing UI evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants