Repository navigation
fix(web): hovering an expanded command row no longer shifts its text - #12614
atharvadeosthale wants to merge 2 commits into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The PR is a small, self-contained UI bug fix that keeps timestamps in layout flow only for expanded rows, preventing hover-induced text reflow while preserving collapsed-row behavior. It introduces no schema, infrastructure, security, billing, default, or static-analysis changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingdotgg/t3code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthrough
ChangesWork entry timestamp positioning
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Expanded rows reserve space for the timestamp to keep text from shifting on hover or focus, while collapsed rows retain their existing behavior. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description clearly explains the problem, change, rationale, and manual verification. It includes before and after screenshots. However, it does not provide the required Scope and approval section or explain why this focused fix qualifies without prior approval. The interaction evidence also does not include the requested short recording. Resolution Add a Scope and approval section with the linked issue or maintainer approval, or explain why this obvious focused fix qualifies without prior discussion. Add a short recording if hover interaction evidence is needed, and correct the checklist to reflect the screenshots and recording that are actually included.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hey @juliusmarminge, slight bump for this PR, this fixes a problem that irritates me everyday :D Sorry for the ping, I will avoid pinging for this PR from now on. |
Dismissing prior approval to re-evaluate f27a879
What Changed
On an expanded work entry row, the hover timestamp now always reserves its width and stays invisible until the row is hovered or focused. Collapsed rows are unchanged: the timestamp still takes no space until hover.
One added
classNameprop inMessagesTimeline.tsx.Why
Since #8641, the timestamp switches from
absolutetostaticon hover so it never overlaps the row text. On a collapsed row that only truncates the one-line preview a little earlier. On an expanded row the command text wraps, so taking width away on hover re-wraps the whole command, and the block jumps on every hover in and hover out.Reserving the width up front on expanded rows means hover only changes opacity.
Checked in the dev web app against a copy of real thread data, on an expanded 510-character command row. Text width (575.39px), text height (136.5px), and row height (177.625px) are identical hovered and not hovered. Collapsed rows still compute
position: absolutefor the hidden timestamp.UI Changes
Before:
before.mp4
After:
after.mp4
Checklist
Claude Fable 5.1 via Claude Code in T3 Code