Skip to content

fix(web): hovering an expanded command row no longer shifts its text - #12614

Open
atharvadeosthale wants to merge 2 commits into
pingdotgg:mainfrom
atharvadeosthale:fix/expanded-row-timestamp-shift
Open

atharvadeosthale wants to merge 2 commits into
pingdotgg:mainfrom
atharvadeosthale:fix/expanded-row-timestamp-shift

Conversation

@atharvadeosthale

@atharvadeosthale atharvadeosthale commented Sep 19, 2026 •

Copy link
Copy Markdown

What Changed

On an expanded work entry row, the hover timestamp now always reserves its width and stays invisible until the row is hovered or focused. Collapsed rows are unchanged: the timestamp still takes no space until hover.

One added className prop in MessagesTimeline.tsx.

Why

Since #8641, the timestamp switches from absolute to static on hover so it never overlaps the row text. On a collapsed row that only truncates the one-line preview a little earlier. On an expanded row the command text wraps, so taking width away on hover re-wraps the whole command, and the block jumps on every hover in and hover out.

Reserving the width up front on expanded rows means hover only changes opacity.

Checked in the dev web app against a copy of real thread data, on an expanded 510-character command row. Text width (575.39px), text height (136.5px), and row height (177.625px) are identical hovered and not hovered. Collapsed rows still compute position: absolute for the hidden timestamp.

UI Changes

Before:

before.mp4

After:

after.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Claude Fable 5.1 via Claude Code in T3 Code

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 19, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 19, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f27a879

Macroscope's review found this PR approvable — The PR is a small, self-contained UI bug fix that keeps timestamps in layout flow only for expanded rows, preventing hover-induced text reflow while preserving collapsed-row behavior. It introduces no schema, infrastructure, security, billing, default, or static-analysis changes.

Notes:

  • Diff unchanged. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 23ff961a-4f47-4450-808f-521d0a0117d7

📥 Commits

Reviewing files that changed from the base of the PR and between f27a879 and 5e803a8.

📒 Files selected for processing (1)
  • apps/web/src/components/chat/MessagesTimeline.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

SimpleWorkEntryRow gives the timestamp a static class when expanded. Collapsed rows retain the existing positioning behavior.

Changes

Work entry timestamp positioning

Layer / File(s) Summary
Conditional timestamp positioning
apps/web/src/components/chat/MessagesTimeline.tsx
Expanded work entries pass the static class to the timestamp. Collapsed work entries pass no class name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: maria-rcks

Merge Risk: ⚪ Minimal · up to 5e803

Expanded rows reserve space for the timestamp to keep text from shifting on hover or focus, while collapsed rows retain their existing behavior. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly explains the problem, change, rationale, and manual verification. It includes before and after screenshots. However, it does not provide the required Scope and approval section… Add a Scope and approval section with the linked issue or maintainer approval, or explain why this obvious focused fix qualifies without prior discussion. Add a short recording if hover interaction evidence is needed, and correct the checkl…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the web fix: expanded command rows no longer shift their text on hover. It is concise and uses the required conventional commit format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem, change, rationale, and manual verification. It includes before and after screenshots. However, it does not provide the required Scope and approval section or explain why this focused fix qualifies without prior approval. The interaction evidence also does not include the requested short recording.

Resolution

Add a Scope and approval section with the linked issue or maintainer approval, or explain why this obvious focused fix qualifies without prior discussion. Add a short recording if hover interaction evidence is needed, and correct the checklist to reflect the screenshots and recording that are actually included.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@atharvadeosthale

atharvadeosthale commented Sep 20, 2026 •

Copy link
Copy Markdown
Author

Hey @juliusmarminge, slight bump for this PR, this fixes a problem that irritates me everyday :D

Sorry for the ping, I will avoid pinging for this PR from now on.

@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 1, 2026 — with ChatGPT Codex Connector
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 1, 2026 03:24

Dismissing prior approval to re-evaluate f27a879

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants