fix(settings): scheduled-task saves only write the fields that changed by saphid · Pull Request #12530 · pingdotgg/t3code

saphid · 2026-09-19T02:46:09Z

Stacked on #11592 and #12529. Until those merge, this diff also shows their commits; review only fix(settings): scheduled-task saves only write the fields that changed.

Problem

Web and mobile Settings saved a task as a full-row upsert built from the form's snapshot. A save could undo an agent's or another device's edit to a field the user never touched.

Fix

New scheduledTasks.update WS RPC over ScheduledTaskService.update, with the operate scope.
Both Settings forms send a patch of only the fields that changed since the editor opened. Creates still use upsert.
update gains modelSelection, runtimeMode, and nextProjectId. update and upsert reject a project/thread pair that could never dispatch; moving a bound task unbinds it explicitly, and the web Project field says so before saving.

No visual change beyond that one hint line on the Project field.

Tests

scheduledTasks.logic.test.ts (web patch builder), scheduledTaskDraft.test.ts (mobile patch builder), ScheduledTaskService.test.ts (runtimeMode patch, model selection and project moves, binding validation). Server, web, and mobile typechecks: 0 errors.

Split from the original #11592 by Claude Fable 5.1 via Claude Code; original implementation with SWE-2 High via Devin CLI. One complete independent review by SWE-2 Max; its findings were fixed, and the fixes were then reviewed by Claude Fable 5.1 only.

🤖 Generated with Claude Code

…ator Ports pingdotgg#8600's server-owned settlement to orchestration v2 instead of keeping client-side evaluation. A ThreadSettlementService sweep runs at startup, on auto-settle settings changes, and once per minute: it evaluates inactivity and merged or closed pull requests over v2 thread shells and dispatches the new guarded thread.auto-settle command, which rejects threads that changed after the sweep's snapshot or carry any explicit override, then reuses the orchestrator's settle lifecycle. With the server deciding, the clients drop their effectiveSettled evaluation and partition on the persisted settledOverride like main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Adopts main's round-19 features into the v2 stack: payload-budgeted orchestration replay (pingdotgg#8992), sidebar row subscription leases (pingdotgg#9052), tool group virtualization and scroll anchoring (pingdotgg#9106), repeated-command and browser-group presentation, inline assistant citations (pingdotgg#9146), per-cwd provider skills discovery (pingdotgg#8778), Claude composer skill dispatch (pingdotgg#9128), grok health probe and model negotiation (pingdotgg#9154), and the failed-tool thinking fallback (pingdotgg#9165). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Round 17 adopted main's pingdotgg#8850 ComposerBanner.Attachment (mx-auto plus the standalone drawer-inset width) without main's matching mounts, so the stash tab's ml-auto lost to the attachment's auto right margin and the tab centered over the composer. Column now spans its attachments like main does, the stash tab zeroes the right margin, and the stash menu keeps the full dock width. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The branch had drifted from main's composer and work-log design in ways unrelated to orchestration v2: a pre-revert "Working for" shoulder tab on the composer (main reverted pingdotgg#8693 and re-landed pingdotgg#8734 without it), an inline stash variant plus in-flow stash menu, expanded tool rows that hid their icons, an unmounted woke-thread banner, a composer scroll observer main never had, and a right-panel toggle that lost its showRightPanelControl gate so it rendered twice with the panel open. ChatComposer and its satellites now start from main's files with only the v2 delta re-applied (dispatch modes, queued-message editing, runtime request ids, response capability). Background tasks surface as a ChatView banner in main's backgroundLiveness shape instead of a composer tab. SimpleWorkEntryRow takes main's PlainWorkEntryRow body with the V2ItemInspector kept behind the expander. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Renumbers the v2 migrations 044-052 to 045-053 behind main's 044_ClearAutomaticProjectModelDefaults, and adopts main's sticky new-thread selection (pingdotgg#9164), local-only worktree bases in the v2 launch path (pingdotgg#8751), the PR summary read for settlement (pingdotgg#9176), Claude per-cwd skills (pingdotgg#9210), the provider editor redesign with the branch's dedicated environment fields re-grafted (pingdotgg#8508), and the client half of continue-threads-across-restart (pingdotgg#9167). The server-side continuation markers stay unported: they live in the v1 session directory, and v2 recovery terminalizes running runs on restart, so the capability is withheld until the v2 runtime carries them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Index event sequence lookups, recover only threads with pending work, and page projection verification and rebuilds. Bound provider event logging and omit turn histories when resuming Codex threads. Allow delegated thread identifiers through relay routes. Add focused regression coverage and document the performance constraints.

Retain main's composer, work-log, settings, mobile and performance changes through c8f77e0 while preserving v2 runs, queued messages, provider handoffs and durable history. Port native compaction and logout, asynchronous Codex questions, provider usage accounting, automatic settlement and PR refresh into the v2 services. Bound live event retention during replay and delivery, measure thread replay before decoding, and read checkpoint metadata without loading transcripts or patches. Keep main migrations through 047 and move the v2 migrations to 048–058. Preserve the existing branch history and the pre-rebase backup. Model: GPT-6. Harness: Codex.

- Preserve Codex turn identity while suppressing duplicate diff notifications - Optimize settlement projections and isolate thread visit handling - Add concurrency and regression coverage across server and mobile

Restore the completed work timer divider and text size from main. Keep todo-list progress in the composer and omit it from web and mobile timeline entries, including completed task lists. Verified pending, running, and completed task projection; 187 focused web tests and 35 mobile tests pass. Web and mobile typechecks pass.

Show Send when a running thread has draft content. Separate submission follow from first-message anchoring so later sends do not reserve extra blank space. Restore Android initial composer insets and iOS focus-aware dictation insets. Keep opening and final assistant replies visible around completed folds, anchoring Worked for at the first hidden item while preserving v2 relationship cards and execution-attempt behavior. Validation: 107 focused tests and the mobile typecheck pass. Formatting passes; scoped lint and React Doctor report warnings but no errors. No simulator run.

…dotgg#7427)

…rk (pingdotgg#4793) Co-authored-by: Julius Marminge <julius0216@outlook.com>

…ingdotgg#7105) Co-authored-by: Julius Marminge <julius0216@outlook.com>

Retain main's changes while preserving v2 orchestration, queue/steer controls, composer-only tasks, timeline timers, and mobile scrolling fixes. Port opt-in restart continuation through durable v2 effects, with shutdown race guards, activation gating, retry deduplication, and native Codex resume. Use narrow projection reads for control effects and runtime-request replies. Surface Claude fallback notices without failing the turn or hiding the notice. Report missing workspace folders before provider startup. Carry over custom models and prices, bounded client caches and stream cleanup, lazy image loading, persistent changed-file trees and sidebar filters, Safari cookie import, theme fixes, POSIX file-link case, private-host favicon filtering, native provider update paths, and platform portability updates. Migration ids remain unchanged. Validated scoped typechecks and focused server, web, mobile, client-runtime, contracts, desktop, shared, SSH, script, and resource-monitor tests. Preserved all 347 original commits and checked the final tree against both saved tips. Model: GPT-6. Harness: Codex.

Worktree preparation previously exposed only a generic fetch failure. Classify known authentication, network, repository access, and reference-lock errors using stable Git diagnostics, without retaining raw output or credentials. Unknown failures keep the existing generic message. Cover failure classification and redaction, a real missing local remote, and propagation into a failed prepared run without creating a worktree or running setup. The launch test waits for the persisted failure event. Validation: 38 focused tests, server typecheck, and scoped lint passed.

Carry main's session refresh, provider maintenance, runtime diagnostics, composer focus, preview, usage, and mobile outbox fixes into the v2 branch. Keep queue/steer submission, composer-only task progress, v2 subagent cards, and LegendList scroll ownership. Project thread and shell events before transport buffering while retaining full durable history. Dismiss native questions when provider turns finish, with a transaction guard that preserves answers submitted concurrently. Port Claude limit notices and Codex file approval details to v2 adapters. Validated with focused server, web, mobile, client-runtime, shared, desktop, and marketing tests; affected package typechecks and scoped lint pass. All 349 branch commits retain their authors and messages. Migration files and the previous worktree-fetch, stash, panel, and mobile inset fixes remain unchanged.

Offline CLI and HTTP project removal dropped force and left native v2 threads behind. Move the nonempty-project guard and durable child cleanup into the shared project service, and forward force from CLI, HTTP, and WebSocket calls. Reuse the thread deletion planner and command lock, hydrate migrated history before attachment cleanup, and validate child receipts. Commit the project deletion after its children so failed cleanup can be retried safely. Validation covers CLI deletion with active and archived threads, missing workspaces, durable cleanup, partial retries, migrated attachments, receipt collisions, and concurrent thread updates. Scoped server tests, typecheck, and lint pass. Implemented with Codex (GPT-6).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

…dotgg#9930) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

…tgg#9903) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…gg#12509)

…gdotgg#12510)

…gdotgg#12352)

…pingdotgg#12514) Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…lity

updateScheduledTask listed every task, merged a stale snapshot into a full-row upsert, and wrote it back. Concurrent disjoint edits clobbered each other, and an edit racing a delete could resurrect the task. Add ScheduledTaskService.update: a scoped read plus a targeted column UPDATE in one transaction. Only supplied fields are written, the UPDATE can never insert, and a missing or cross-project task returns Option.none, which the MCP layer maps to task_not_found. next_run_at is recomputed only when schedule or enabled actually change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Run completion, stuck-run release, dispatch, and setEnabled each re-read the task and then wrote in a separate statement, so an edit committed between the two had its next_run_at overwritten from the older schedule, and a pause or delete landing after the dispatch re-read could still fire. Put each re-read and its write in one transaction with the contention retry, and guard the missed-run reschedule on the next_run_at it was computed from. Tests pin the due-read to dispatch gap (pause, postpone, delete, and the no-edit case), an edit committed mid-run on the success and interrupted paths, and a contended completion write retrying instead of stranding the task as running. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Web and mobile Settings saved a task as a full-row upsert built from the form's snapshot, so a save could undo an agent's or another device's edit to a field the user never touched. Add a scheduledTasks.update WS RPC over ScheduledTaskService.update and have both Settings forms send a patch of the dirty fields. update gains modelSelection, runtimeMode, and nextProjectId, and rejects a project/thread pair that could never dispatch; moving a bound task unbinds it explicitly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

macroscopeapp · 2026-09-19T02:48:30Z

+        submissionPending.current = false;
+        return;
+      }
+      const patch = buildScheduledTaskUpdateInput(draft, liveTask);


🟡 Medium settings/SettingsScheduledTasksRouteScreen.tsx:625

Saving a legacy interval task with everyMs < 60_000 reports success without updating the task, so it remains below the one-minute minimum even though the UI displays 1 and says saving will enforce that minimum. buildScheduledTaskUpdateInput returns null when the normalized draft matches the normalized baseline, and this branch skips update and calls onSaved; ensure the update input still includes the normalized one-minute schedule for this legacy case.

🤖 Copy this AI Prompt to have your agent fix this:

In file @apps/mobile/src/features/settings/SettingsScheduledTasksRouteScreen.tsx around line 625: Saving a legacy interval task with `everyMs < 60_000` reports success without updating the task, so it remains below the one-minute minimum even though the UI displays `1` and says saving will enforce that minimum. `buildScheduledTaskUpdateInput` returns `null` when the normalized draft matches the normalized baseline, and this branch skips `update` and calls `onSaved`; ensure the update input still includes the normalized one-minute schedule for this legacy case.

Real, and web had the same gap. A sub-minute interval is shown as one minute, so the normalized draft never looked dirty. Fixed in 0477c4a for both clients: a live sub-minute interval always writes the normalized schedule; tests added on web and mobile.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp · 2026-09-19T02:49:11Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new scheduled-task update RPC and changes shared persistence, scheduler execution, MCP behavior, and project/thread binding semantics across production paths. It also touches authorization code and has an unresolved Medium-severity legacy-interval correctness thread, so human review is warranted.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

…ngs, and legacy intervals - Mobile: saving before the task list loads silently did nothing; fall back to the snapshot the editor opened with. - Web: the "detaches the thread binding" hint read the opening draft, so a binding another client committed mid-session was removed without warning. It now reads the live task, like the save does. - Web and mobile: a legacy sub-minute interval shows as one minute, so it never looked dirty and the save skipped it. Saving now writes the normalized schedule. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

update accepted any nextProjectId, so a task could be moved into a missing project, save successfully, and then fail every run at launch. Check the destination inside the update transaction. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

saphid · 2026-09-19T02:56:56Z

Reversing my earlier dismissal of the nextProjectId finding (ScheduledTaskService.ts:959). nextProjectId is new surface in this PR, so it should validate its input even though upsert never has: 6980ee9 checks the destination project inside the update transaction and rejects an unknown one, with a test. The legacy sub-minute interval finding is fixed in 0477c4a for web and mobile.

juliusmarminge · 2026-09-21T20:16:21Z

Closing. The current head of #11592 (f19067f3fc) re-absorbed this split: the scheduledTasks.update RPC, ws.ts / RpcAuthorization.ts wiring, the web scheduledTasks.logic.ts patch builder, and the mobile scheduledTaskDraft.ts patch path are all there. I'd rather review #11592 as one PR than the same change in two shapes. If you would prefer to keep the split, drop the content from #11592 first and re-stack this on it.

One thing to double-check in #11592: this branch's 6980ee950c validates that nextProjectId exists inside the update transaction (project:does-not-exist). Make sure #11592 carries that too.

juliusmarminge and others added 30 commits September 18, 2026 17:45

fix(orchestration): stabilize Codex turn mapping and settlement

9f6df3c

- Preserve Codex turn identity while suppressing duplicate diff notifications - Optimize settlement projections and isolate thread visit handling - Add concurrency and regression coverage across server and mobile

fix(orchestrator): Stop treating a wait timeout as a dead child (ping…

ecc279e

…dotgg#7427)

fix(orchestrator): Show when a completed delegated child still has wo…

1788cfc

…rk (pingdotgg#4793) Co-authored-by: Julius Marminge <julius0216@outlook.com>

fix(orchestrator): Stop finished Codex turns from sitting on Waiting (p…

5678698

…ingdotgg#7105) Co-authored-by: Julius Marminge <julius0216@outlook.com>

chore: format v2 files flagged by CI

2dd759a

test(server): include the shell indexes migration

42b7286

fix(client-runtime): resolve work log source imports

c7ed38e

test(server): refresh replay runtime instruction expectations

3fce7bf

test(server): correlate OpenCode replay message identities

014898e

ci: run checks on v2 branch pushes

1c3b2dd

test(server): use Effect Vitest for Cursor provider checks

f0e829c

fix(mobile): render generic message attachments (pingdotgg#9929)

94d6036

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

fix(mobile): use the archive eligibility guard when dispatching (ping…

7bef663

…dotgg#9930) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>

fix(orchestration): persist linked pull requests (pingdotgg#8689)

a3733a3

feat(mcp): update thread metadata (pingdotgg#8690)

d7780db

fix(server): keep old failures from waking snoozed V2 threads (pingdo…

2e79053

…tgg#9903) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

refactor(shared): share model-selection command choice (pingdotgg#10577)

557e287

juliusmarminge and others added 14 commits September 18, 2026 17:45

fix(web): reconcile sidebar search with V2 environment subscriptions

921dc87

fix(server): reconcile PR preview and checks fixtures

56a9c87

fix(mobile): preserve merge-back action in shared thread header

ac7468a

fix(server): unblock orchestrator CI checks

76fdadd

fix(web): anchor turn duration below the initiating prompt

162b2ca

fix(mobile): submit v2 previews to Play closed testing

68224fa

fix(mobile): remove stale preferences type import

371757e

fix(desktop): allow V1 and V2 to run concurrently (pingdotgg#12480)

8bacaf3

fix(antigravity): accept supported legacy handshake versions (pingdot…

3d212e4

…gg#12509)

fix(cursor): preserve SDK runtime chunks and helpers in packages (pin…

d6df3fe

…gdotgg#12510)

feat(server): preserve budgeted history across provider handoffs (pin…

e56b79e

…gdotgg#12352)

fix(server): decode v1 message events persisted with a reasoning role (…

49357d0

…pingdotgg#12514) Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>

test(server): align V2 fixtures with OTLP log configuration

9cdec02

fix(acp): reconcile elicitation validation with V2 protocol compatibi…

9b4fd10

…lity

github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 19, 2026

github-actions Bot and others added 3 commits September 19, 2026 12:48

macroscopeapp Bot reviewed Sep 19, 2026

View reviewed changes

saphid force-pushed the work/pr11592-split-3-settings-partial-save branch from 43d1d5a to fa0e7d3 Compare September 19, 2026 02:48

github-actions Bot and others added 2 commits September 19, 2026 12:52

juliusmarminge force-pushed the t3code/codex-turn-mapping branch 3 times, most recently from a1f8051 to 0337dd6 Compare September 21, 2026 05:40

juliusmarminge closed this Sep 21, 2026

Navigation Menu

fix(settings): scheduled-task saves only write the fields that changed - #12530

fix(settings): scheduled-task saves only write the fields that changed#12530
saphid wants to merge 576 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:work/pr11592-split-3-settings-partial-save

saphid commented Sep 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot Sep 19, 2026

Uh oh!

saphid Sep 19, 2026

Uh oh!

macroscopeapp Bot Sep 19, 2026

Uh oh!

macroscopeapp Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

saphid commented Sep 19, 2026

Uh oh!

juliusmarminge commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

saphid commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

saphid Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot Sep 19, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

saphid commented Sep 19, 2026

Uh oh!

juliusmarminge commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

saphid commented Sep 19, 2026 •

edited

Loading

macroscopeapp Bot commented Sep 19, 2026 •

edited

Loading