Skip to content

fix(web): keep portaled menus clickable over Electron drag regions #12527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Sep 20, 2026
Merged

fix(web): keep portaled menus clickable over Electron drag regions #12527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/web/src/components/ui/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ function MenuPopup({
<MenuPrimitive.Popup
className={cn(
"dropdown-glass relative flex origin-(--transform-origin) rounded-lg shadow-[0_16px_40px_-18px_rgb(0_0_0/55%)] outline-none focus:outline-none dark:shadow-[0_18px_44px_-18px_rgb(0_0_0/80%)]",
// Portaled menus can overlap an Electron window drag region (e.g.
// the Review panel header). Drag hit-testing ignores z-index, so
// the topmost row would stay unhoverable without this opt-out.
"[-webkit-app-region:no-drag]",
!hasExplicitWidthClass && "min-w-32",
className,
)}
Expand Down
Loading