Repository navigation
Conversation
A long unbroken path pasted into the Command field stretched the whole form past the dialog, clipping the right edge of every control and adding a horizontal scrollbar. The shared Textarea sits in an inline-flex wrapper, so its width:100% is indefinite and its automatic minimum size falls back to the content's min-content width, which field-sizing:content derives from the longest unbreakable run. The surrounding fieldset has min-width:min-content, so that width propagated to the whole form. Give the control min-w-0 max-w-full and overflow-wrap:anywhere so it wraps in place and grows vertically instead of sideways. Display only; the stored command and its line breaks are unchanged.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, isolated UI bug fix that keeps long textarea values within their containers by adjusting width and wrapping styles. It adds a focused static-rendering test and does not affect persisted data, APIs, workflows, or production infrastructure. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe textarea now constrains its width and wraps long unbroken values. A server-rendered test verifies the added classes. ChangesTextarea overflow prevention
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The textarea styling change addresses long-command overflow without introducing a concrete merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
juliusmarminge
added
the
macroscope-review
ChatGPT Codex Connector
This branch has not been deployed
2 participants
What Changed
The shared
Textareacontrol now getsmin-w-0 max-w-fullandwrap-anywhere, so a long value wraps in place and grows the field vertically instead of sideways.Why
Fixes #11443.
Pasting a long unbroken path into the Command field stretched the whole Add Action form past the dialog. The right edge of every control was clipped and a horizontal scrollbar appeared under the form.
The control is a flex item inside the
inline-flexwrapper span. That wrapper is shrink-to-fit, so the control'swidth: 100%is indefinite and its automatic minimum size falls back to the content-based minimum, whichfield-sizing: contentderives from the longest unbreakable run in the value. The surroundingfieldsetcarries the UAmin-width: min-content, so that width propagated to the entire form and overflowed themax-w-lgpopup.min-w-0drops the automatic minimum,max-w-fullkeeps the field inside the wrapper, andoverflow-wrap: anywheregives a long path a break opportunity. Display only. The stored command and its intentional line breaks are unchanged. I put the constraint on the shared control rather than a local class on this one field, as suggested on the issue, so the other dialogs that use a textarea get the same protection. I checked the other call sites. They are all freeform text and none rely on horizontal growth.I left
whitespace-pre-wrapout: the UA stylesheet already applies it to textareas, so it would be a no-op.The example command in the issue has hyphens and does not overflow. The path from the screenshot, with no break opportunities, does. Measured unfixed: textarea 599px inside a 462px form. Fixed: 460px.
UI Changes
Before and after at the same window size, with the command from the issue screenshot:
Checklist
Summary by CodeRabbit