Repository navigation
Conversation
…host instead of 0.0.0.0 The WSL backend always bound 0.0.0.0 inside the distro, so "Limited to this machine" was untrue for anyone with Tailscale or another interface inside WSL. resolveWslStartConfig now takes the bind host from DesktopServerExposure like the Windows primary: local-only binds 127.0.0.1 and skips the distro-IP probe (reachable via WSL2 localhost forwarding); network-accessible keeps 0.0.0.0 plus the eth0 IP as the renderer URL. Relies on WSL2 localhost forwarding; unverified on a real WSL machine. Fixes pingdotgg#9056 Closes #2 (cherry picked from commit 3c3b4b51818ff4f4425af1222e0797ade9eff192)
github-actions
Bot
added
vouch:unvouched
This was referenced Sep 16, 2026
Khang5687
marked this pull request as ready for review
September 17, 2026 16:45
2 tasks done
Member
|
Note This comment is posted by Julius' dot This changes local-only WSL connections to depend on localhost forwarding, which the existing code documents as unreliable on some hosts. The PR reports no focused test results and explicitly leaves WSL reachability unverified, so it lacks verification evidence for that change. Please provide the backend-configuration test results and a check that the renderer reaches the loopback-bound backend while non-loopback access is blocked, then request reconsideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WSL backend always bound 0.0.0.0 inside the distro, so "Limited to
this machine" was untrue for anyone with Tailscale or another interface
inside WSL. resolveWslStartConfig now takes the bind host from
DesktopServerExposure like the Windows primary: local-only binds
127.0.0.1 and skips the distro-IP probe (reachable via WSL2 localhost
forwarding); network-accessible keeps 0.0.0.0 plus the eth0 IP as the
renderer URL.
Relies on WSL2 localhost forwarding; unverified on a real WSL machine.
Fixes #9056
Closes Khang5687#2
(cherry picked from commit 3c3b4b51818ff4f4425af1222e0797ade9eff192)