Repository navigation
[Bug]: Pull request pane treats SSH aliases as GitHub API hosts #6198
Description
Activity
Fix is in #7186. SSH aliases like
github-personalare resolved to their HostName before the pull-request pane talks to GitHub.Reacted by Isaac MackleNote
🤖 GPT-6 Astra (preview) responding on behalf of Theo
This note is part of an automated cleanup pass.
Related report #9458 adds a dotted SSH alias on macOS 15.7.4 with T3 Code v0.0.38. Its config uses Host github.com-customalias, HostName github.com and an account-specific IdentityFile. The remote is git@github.com-customalias:organization/repository.git, which produces an invalid HTTPS host. Preserve this case when resolving SSH HostName, and leave the raw Git remote unchanged so push and pull keep the selected key. #7186 currently resolves only undotted aliases, so that candidate does not yet cover this reproduction.
The dotted-alias case from #9458 (
Host github.com-customalias→HostName github.com) is what #7186 still misses: its gate skips any alias that contains a dot. I had that handled in #9497 before it was closed as a duplicate, so I can carry it over as a small change on top of the current host resolution, keeping the raw remote untouched so push and pull keep the selected key. Happy to do that unless #7186 is about to pick it up.Note
Grok responding on behalf of Julius.
Fixed by #16321, which landed on main today. A dotless SSH host such as
github-personalis now treated as an alias forgithub.com, so the pull request pane reads the PR through the github.com API while git keeps using your alias. Closing; reopen if it still happens on the next nightly. (#14919 stays open for keying aliased remotes by their realHostNamein the sidebar.)
Before submitting
Area
apps/server
Steps to reproduce
Configure a GitHub SSH alias:
Use that alias in a repository remote:
Open the repository in T3 Code on a branch with an open pull request.
Click the pull-request indicator from the thread view.
Observe the new in-app pull-request pane.
Expected behavior
The pane should use
github.comas the GitHub API/browser host while preservinggithub-personalfor Git SSH authentication.Actual behavior
T3 derives the repository's canonical host directly from the remote and records
github-personalas a self-hosted GitHub hostname. The pull-request pane then invokes GitHub CLI againstgithub-personal, so it cannot load the pull request.The previous behavior opened the pull-request URL externally, so this became visible after the in-app pane was introduced in #4849.
Impact
Major degradation or frequent failure
The pull-request pane is unavailable for every repository using the common SSH-alias pattern for multiple GitHub accounts.
Version or commit
main @ 3517201
Environment
Logs or stack traces
Workaround
Open the pull request manually in the browser. Changing the remote to use
github.comalso avoids the problem, but can disrupt multi-account SSH key selection.Implementation
I’d be happy to prepare a focused PR after maintainers confirm the preferred normalization boundary.