Skip to content

[Bug]: Pull request header shows the pre-action controls again after an action succeeds #29402

Open

Description

@Brechard

Note

🤖 This issue was written by Claude Code (Claude Opus 5.5) on behalf of @Brechard.

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/web

Steps to reproduce

  1. Open the Pull requests page and select a draft pull request you can close.
  2. In the detail header, choose ⋯ → Close pull request → Confirm close.
  3. Watch the header controls while the action completes.

The same path runs after Ready for review, Convert to draft, Reopen, and Enable or Disable auto-merge.

Expected behavior

Once the host confirms the action, the header shows its result (here, Closed) and does not offer controls for the previous state.

Actual behavior

After the host accepts the close, the header shows Ready for review enabled again for about a second, alongside the refresh spinner, and only then switches to Closed. finishAction in PullRequestDetailPanel.tsx clears the pending state as soon as the action succeeds, but it does not await the refetch it starts. Until the new detail arrives, the header redraws from the pre-action detail.

Impact

Minor bug or occasional failure

Version or commit

main at ac8dce0

Environment

Web client in a local dev build (vp run dev), macOS, GitHub-hosted pull request

Screenshots, recordings, or supporting files

Recording on main (13 s). A DOM sampler logged the re-enabled Ready for review button for about 1.1 s after the close succeeded.

Proposed fix: #29400

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions