Repository navigation
[Bug]: Creating a thread from a pull request does not link the pull request to the thread #15721
Description
Activity
Note
Grok responding on behalf of Julius.
Triage
Thanks for tracing all three checkout paths, @gertzgal. I didn't find another issue covering this.
What I found
I checked
mainat4ee6bfd. Checkout prepares the branch and points a thread at it, but it never writes athread.pull-request.link.GitManager.preparePullRequestThreadresolves and returns the pull request. It only usesthreadIdfor the setup script and never dispatches a link. Creating a pull request from a thread does link it, vialinkCreatedPullRequest, because that thread already exists.- Every checkout caller keeps only
branchandworktreePathand drops the resolved pull request. That includesPullRequestThreadDialogwithhandlePreparedPullRequestThread,PullRequestDetailPanel, andusePullRequestHandoffs. Several of these pass the id of a draft. Drafts are client state, andthread.pull-request.linkloads an existing server thread, so linking at prepare time would have nothing to attach to.PersistedDraftThreadStatehas no pull request field. - Once the draft becomes a thread,
ThreadPullRequestServicecan store a discoveredbranchPullRequest, and badges fall back to it (useLinkedThreadPullRequest). The linked list, the pull-requests panel, snapshot sync, stack siblings, and watch all read links, though, so they stay empty until someone links manually. - Ask and Explain don't check out and don't link either. Mobile has no checkout-from-pull-request path.
Likely fix area
- One option is to store the resolved pull request on the draft that receives the checkout. Then dispatch
thread.pull-request.linkwhen that draft becomes a server thread. All three web callers already haveresult.pullRequest. - Today's link sources are
manual,created,agent,stack, andstack-dismissed. A checkout link might want its own source.
A maintainer will decide on the fix direction.
- added a commit that references this issue
on Oct 5, 2026
Before submitting
Area
apps/web
Steps to reproduce
Expected behavior
The pull request the thread was created from is linked to that thread, the same as if it had been linked through the Link pull request dialog or the
link_pull_requestMCP tool. Linked-PR sync, watching, and the sidebar/thread badges then treat it as the thread's pull request.Actual behavior
The worktree is prepared and the thread is pointed at the PR branch, but no link is recorded. The PR must be linked by hand afterwards.
None of the paths that prepare a PR checkout write a link:
GitManager.preparePullRequestThread(apps/server/src/git/GitManager.ts) usesthreadIdonly to run the project setup script.preparePullRequestThreadsucceeds, each caller only re-points the thread at{ branch, worktreePath }and never dispatchesthread.pull-request.link:ChatView.tsx→handlePreparedPullRequestThreadpullRequest/PullRequestDetailPanel.tsx(checkout hand-off)pullRequest/usePullRequestActions.ts(usePullRequestHandoffs)Because the server method already resolves the pull request and receives the
threadId, linking there would cover all three web paths plus any other caller with no client changes.Impact
Minor bug or occasional failure
Version or commit
main @ 4ee6bfd
Environment
macOS, T3 Code desktop
Workaround
Link the pull request manually from the thread's Link pull request dialog after the checkout completes.