Skip to content

Assess composer-to-Stash motion and existing PR #10248

Description

@saphid

Review existing PR #10134 without editing its dirty worktree or branch. Verify shallow arc, common 550 ms start/deadline, final destination layout, interruption and reduced motion. Reuse the existing PR if it covers the suggestion; only build a separate focused follow-up if a concrete gap remains.

Requested by Alex after the T3 UI motion audit. First record an independent Astra-medium accept/revise/reject verdict with source evidence. Accepted changes should end in small focused PRs; do not implement a rejected suggestion.

Use the installed shadcn-motion-ui skill and Human Interface Craft guidelines (feedback, relationship, continuity, accessibility, signature moments). Consult current official docs, reuse local primitives, verify installed API compatibility and add exact source references. Respect native platforms, reduced motion, interruptions, responsiveness, focus, and performance. No continuous repaint loops or framework rewrites.

Acceptance:

  • Independent assessment and overlap check recorded.
  • Accepted scope implemented and focused checks pass, or rejection/dependency documented.
  • Best-effort independent cross-provider review recorded.
  • Real before/after motion evidence and PR linked, with any missing evidence disclosed as a draft-readiness gap.

Do not change live user data, the dirty primary checkout, existing Stash worktree, or unrelated work. No merge or deployment is requested.

Activity

  1. saphid commented on Sep 6, 2026

    @saphid
    ContributorAuthor

    Astra medium assessment: revise and reuse existing PR #10134; no duplicate PR. Published head 66ca24083 uses custom composerStashKeyframes/Element.animate, a teardrop path, a single destination measurement and a 550 ms flight. It correctly persists first, marks the clone aria-hidden, and cancels on reduced motion, resize and unmount. It does not establish the requested shallow Motion arc or a shared composer/flight deadline with final-layout retargeting. The dirty local Stash worktree contains an uncommitted Motion implementation addressing those gaps, but that overlay is not this published PR and cannot be treated as shipped or reviewed evidence. That worktree/branch is explicitly protected in this task, so record the gap here and let its existing owner complete/review/capture the overlay in #10134. Human Interface Craft p.13 supports this meaningful transfer as a signature moment; p.10 requires brief, interruptible motion and final-state continuity. No edits made to the existing branch or dirty files.

  2. saphid commented on Sep 6, 2026

    @saphid
    ContributorAuthor

    Independent continuation confirms revise/reuse #10134, with no Stash edits. Inspected published 66ca24083 ComposerStashFlight.tsx: Element.animate with composerStashKeyframes, one destination rectangle, and 550 ms easing. The dirty local overlay imports Motion animate/arc, so it remains a distinct uncommitted candidate. Existing owner must finish that overlay and provide integrated geometry/interruption/reduced-motion proof in #10134; no duplicate PR is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions