cluster: unify default tiflash logger size/count with doc#2683
cluster: unify default tiflash logger size/count with doc#2683xhebox merged 2 commits intopingcap:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 42.37% 42.35% -0.02%
==========================================
Files 424 424
Lines 47043 47041 -2
==========================================
- Hits 19932 19920 -12
- Misses 24425 24433 +8
- Partials 2686 2688 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| logger.count: 10 | ||
| logger.size: "100M" |
There was a problem hiding this comment.
We'd better directly remove these two config from tiup and let tiflash use its default value in the tiflash code.
JaySon-Huang
left a comment
There was a problem hiding this comment.
LGTM
And we should update this behavior in the "Release note" of tiup new version
|
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
What problem does this PR solve?
In the doc https://docs.pingcap.com/tidb/stable/tiflash-configuration/#logger, the
logger.sizeandlogger.countshould be100Mand10, this is not consistent with the default value in the tiup cluster.close #2684
What is changed and how it works?
Unify the logger size and count with doc
Check List
Tests
Code changes
Side effects
Related changes
Release notes: