Skip to content

cluster: unify default tiflash logger size/count with doc#2683

Merged
xhebox merged 2 commits intopingcap:masterfrom
fzzf678:unify_logger_size_count
Feb 28, 2026
Merged

cluster: unify default tiflash logger size/count with doc#2683
xhebox merged 2 commits intopingcap:masterfrom
fzzf678:unify_logger_size_count

Conversation

@fzzf678
Copy link
Copy Markdown
Contributor

@fzzf678 fzzf678 commented Feb 14, 2026

What problem does this PR solve?

In the doc https://docs.pingcap.com/tidb/stable/tiflash-configuration/#logger, the logger.size and logger.count should be 100M and 10, this is not consistent with the default value in the tiup cluster.

close #2684

What is changed and how it works?

Unify the logger size and count with doc

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Remove hardcoded TiFlash logger.size/logger.count from TiUP Cluster’s generated config so TiFlash uses its built-in default log rotation settings.

@ti-chi-bot ti-chi-bot Bot requested a review from srstack February 14, 2026 07:09
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Feb 14, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.35%. Comparing base (c567110) to head (d7eb757).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   42.37%   42.35%   -0.02%     
==========================================
  Files         424      424              
  Lines       47043    47041       -2     
==========================================
- Hits        19932    19920      -12     
- Misses      24425    24433       +8     
- Partials     2686     2688       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/cluster/spec/tiflash.go Outdated
Comment on lines +559 to +560
logger.count: 10
logger.size: "100M"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better directly remove these two config from tiup and let tiflash use its default value in the tiflash code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in d7eb757

Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And we should update this behavior in the "Release note" of tiup new version

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Feb 28, 2026

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

And we should update this behavior in the "Release note" of tiup new version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fzzf678
Copy link
Copy Markdown
Contributor Author

fzzf678 commented Feb 28, 2026

/retest

@xhebox xhebox merged commit 908be86 into pingcap:master Feb 28, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default values of logger.size and logger.count for the TiFlash configuration file parameters are incorrect.

4 participants