Skip to content

cluster: Persistently disable THP#2498

Merged
xhebox merged 1 commit intopingcap:masterfrom
dveeden:cluster_thp
Apr 10, 2026
Merged

cluster: Persistently disable THP#2498
xhebox merged 1 commit intopingcap:masterfrom
dveeden:cluster_thp

Conversation

@dveeden
Copy link
Copy Markdown
Contributor

@dveeden dveeden commented Jan 21, 2025

What problem does this PR solve?

Close None

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
tiup cluster check topology.yaml --apply

And then check /etc/default/grub:

...
GRUB_CMDLINE_LINUX="crashkernel=1G-4G:192M,4G-64G:256M,64G-:512M resume=/dev/mapper/rl-swap rd.lvm.lv=rl/root rd.lvm.lv=rl/swap transparent_hugepage=never"
...

Related changes

Release notes:

TiUP Cluster Check now disables THP persistently

@ti-chi-bot ti-chi-bot Bot requested review from breezewish and srstack January 21, 2025 07:09
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 21, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.35%. Comparing base (73f2c7a) to head (c51dc96).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cluster/manager/check.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2498      +/-   ##
==========================================
+ Coverage   38.33%   42.35%   +4.02%     
==========================================
  Files         424      424              
  Lines       47078    47082       +4     
==========================================
+ Hits        18047    19940    +1893     
+ Misses      26620    24451    -2169     
- Partials     2411     2691     +280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dveeden
Copy link
Copy Markdown
Contributor Author

dveeden commented Jan 21, 2025

/retest

@ti-chi-bot ti-chi-bot Bot added the lgtm label Feb 5, 2025
@xhebox xhebox marked this pull request as draft April 10, 2026 01:40
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2026
@xhebox xhebox marked this pull request as ready for review April 10, 2026 01:40
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2026
@ti-chi-bot ti-chi-bot Bot requested a review from breezewish April 10, 2026 01:40
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 10, 2026

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 02:30:36.448513277 +0000 UTC m=+238907.980925270: ☑️ agreed by breezewish.
  • 2026-04-10 01:43:53.598686477 +0000 UTC m=+1093438.804046533: ✖️🔁 reset by xhebox.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 10, 2026

New changes are detected. LGTM label has been removed.

@xhebox xhebox merged commit 90807f3 into pingcap:master Apr 10, 2026
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants