globalsort: fix stuck when ingesting small kv - #62407
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62407 +/- ##
================================================
+ Coverage 72.9071% 73.8131% +0.9060%
================================================
Files 1754 1785 +31
Lines 484998 497265 +12267
================================================
+ Hits 353598 367047 +13449
+ Misses 109767 107843 -1924
- Partials 21633 22375 +742
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
@D3Hunter: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #62388
Problem Summary:
What changed and how does it work?
consider the memory taken by slice header when splitting range
Check List
Tests
same case in the issue, before this pr, 2 out of 3 runs stuck. after this pr, we run 10 times, all success.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.