Skip to content

parser: Add ADD_COLUMNAR_REPLICA_ON_DEMAND#61159

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
breezewish:wenxuan/acr/parser
May 19, 2025
Merged

parser: Add ADD_COLUMNAR_REPLICA_ON_DEMAND#61159
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
breezewish:wenxuan/acr/parser

Conversation

@breezewish
Copy link
Copy Markdown
Member

@breezewish breezewish commented May 18, 2025

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

Allow SQLs like this in parser:

ALTER TABLE x ADD VECTOR INDEX ... (...) ADD_COLUMNAR_REPLICA_ON_DEMAND;

Note that this PR only changes the parser. It does not take effect currently (so there is no release note needed).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2025
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
This reverts commit e9bca98.
Signed-off-by: Wish <breezewish@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5963%. Comparing base (0d94843) to head (e52e1b1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61159        +/-   ##
================================================
+ Coverage   73.1818%   73.5963%   +0.4144%     
================================================
  Files          1724       1724                
  Lines        477472     477736       +264     
================================================
+ Hits         349423     351596      +2173     
+ Misses       106646     104720      -1926     
- Partials      21403      21420        +17     
Flag Coverage Δ
integration 42.7724% <ø> (?)
unit 72.3830% <62.5000%> (-0.0142%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 47.7467% <ø> (+0.0274%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread pkg/parser/parser.y
/* The following tokens belong to UnReservedKeyword. Notice: make sure these tokens are contained in UnReservedKeyword. */
account "ACCOUNT"
action "ACTION"
addColumnarReplicaOnDemand "ADD_COLUMNAR_REPLICA_ON_DEMAND"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not aligned?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breezewish You can run cd pkg/parser && make fmt.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format is updated, thank you all! @hawkingrei @tangenta

Signed-off-by: Wish <breezewish@outlook.com>
Copy link
Copy Markdown

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also open a document PR

@pingcap pingcap deleted a comment from ti-chi-bot May 19, 2025
@ti-chi-bot ti-chi-bot Bot added the approved label May 19, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap pingcap deleted a comment from ti-chi-bot Bot May 19, 2025
@pingcap pingcap deleted a comment from ti-chi-bot Bot May 19, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 6148d60 into pingcap:master May 19, 2025
24 checks passed
@breezewish breezewish deleted the wenxuan/acr/parser branch May 19, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants