Skip to content

store/driver: set MaxCallRecvMsgSize to MaxInt32 for pd client - #56278

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
rleungx:use-MaxCallRecvMsgSize
Sep 25, 2024
Merged

store/driver: set MaxCallRecvMsgSize to MaxInt32 for pd client#56278
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
rleungx:use-MaxCallRecvMsgSize

Conversation

@rleungx

@rleungx rleungx commented Sep 25, 2024

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #55872.

Problem Summary:

What changed and how does it work?

The original pd client uses the default MaxCallRecvMsgSize which is 4MB.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
  1. tiup playground nightly --kv 3 --pd 1 --db 1 --tiflash 0 --host 10.2.8.101
  2. mysql -h 10.2.8.101 -P 43099 -u root -D test --comments -e "create table t(id bigint primary key)"
  3. execute the following command and wait for it to finish
for i in {1..100}
do
    mysql -h 10.2.8.101 -P 43099 -u root -D test --comments -e "SPLIT TABLE t BETWEEN ($(($i))000000) AND ($(( $i + 1 ))000000) REGIONS 1000" > /dev/null &
done
  1. call the API
curl http://10.2.8.101:33613/tables/test/t/regions
{
 "name": "t",
 "id": 110,
 "record_regions": [
  {
   "region_id": 1358901,
   "leader": {
    "id": 1358902,
    "store_id": 1
   },
   "peers": [
    {
     "id": 1358902,
     "store_id": 1
    },
    {
     "id": 1358903,
     "store_id": 4
    },
    {
     "id": 1358904,
     "store_id": 5
    }
   ],
   "region_epoch": {
    "conf_ver": 5,
    "version": 3057
   }
  },
  {
   "region_id": 1358905,
   "leader": {
    "id": 1358906,
    "store_id": 1
   },
   "peers": [
    {
     "id": 1358906,
     "store_id": 1
    },
    {
     "id": 1358907,
     "store_id": 4
    },
    {
     "id": 1358908,
     "store_id": 5
    }
   ],
   "region_epoch": {
    "conf_ver": 5,
    "version": 3057
   }
  },
...

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@rleungx rleungx changed the title pkg: set MaxCallRecvMsgSize to MaxInt32 for pd client store/driver: set MaxCallRecvMsgSize to MaxInt32 for pd client Sep 25, 2024

@niubell niubell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Sep 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4487%. Comparing base (fd38012) to head (02dd5db).
Report is 841 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56278        +/-   ##
================================================
+ Coverage   73.4525%   75.4487%   +1.9961%     
================================================
  Files          1605       1605                
  Lines        444823     444870        +47     
================================================
+ Hits         326734     335649      +8915     
+ Misses        98037      88770      -9267     
- Partials      20052      20451       +399     
Flag Coverage Δ
integration 49.1592% <100.0000%> (?)
unit 72.5580% <0.0000%> (+0.0145%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.9462% <ø> (+6.9287%) ⬆️

@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 25, 2024
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
@ti-chi-bot

ti-chi-bot Bot commented Sep 25, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 03:18:23.557429775 +0000 UTC m=+1622373.297853709: ☑️ agreed by JmPotato.
  • 2024-09-25 03:19:29.15986923 +0000 UTC m=+1622438.900293169: ☑️ agreed by nolouch.

@ti-chi-bot

ti-chi-bot Bot commented Sep 25, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 25, 2024
@ti-chi-bot
ti-chi-bot Bot merged commit a5e07a2 into pingcap:master Sep 25, 2024
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56284.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 25, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@rleungx
rleungx deleted the use-MaxCallRecvMsgSize branch September 25, 2024 05:26
@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 28, 2024
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56878.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 21, 2025
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59069.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 21, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regions API unavailable when there are too many regions

6 participants