Skip to content

*: set default shard_row_id_bits and pre_split_regions for all tables - #55717

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
jackysp:def_shard
Sep 13, 2024
Merged

*: set default shard_row_id_bits and pre_split_regions for all tables #55717
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
jackysp:def_shard

Conversation

@jackysp

@jackysp jackysp commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #55716

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Introduced variables `tidb_shard_row_id_bits` and `tidb_pre_split_regions`, to change the default values of `shard_row_id_bits` and `pre_split_regions`, avoiding setting them individually for each table.

@jackysp jackysp added the component/ddl This issue is related to DDL of TiDB. label Aug 28, 2024
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Aug 28, 2024
@codecov

codecov Bot commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.3319%. Comparing base (499e45f) to head (04127e4).
Report is 52 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55717         +/-   ##
=================================================
- Coverage   72.8489%   58.3319%   -14.5171%     
=================================================
  Files          1604       1756        +152     
  Lines        445733     643839     +198106     
=================================================
+ Hits         324712     375564      +50852     
- Misses       101000     243773     +142773     
- Partials      20021      24502       +4481
Flag Coverage Δ
integration 41.3738% <53.1250%> (?)
unit 73.6243% <93.7500%> (+1.6630%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 64.3915% <ø> (+18.6506%) ⬆️

@jackysp

jackysp commented Aug 28, 2024

Copy link
Copy Markdown
Contributor Author

/test check-dev

@tiprow

tiprow Bot commented Aug 28, 2024

Copy link
Copy Markdown

@jackysp: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackysp

jackysp commented Aug 28, 2024

Copy link
Copy Markdown
Contributor Author

/retest-required

@jackysp
jackysp requested review from Benjamin2037 and bb7133 August 29, 2024 11:59
@D3Hunter

D3Hunter commented Sep 4, 2024

Copy link
Copy Markdown
Contributor

/hold

new feature need confirm from PM

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2024
@Frank945946

Frank945946 commented Sep 4, 2024

Copy link
Copy Markdown

The default values are the same as in prior versions, and it supports setting the values at the session level. LGTM.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2024
Benjamin2037
Benjamin2037 reviewed Sep 4, 2024
View reviewed changes
Comment thread pkg/ddl/create_table.go
Benjamin2037
Benjamin2037 reviewed Sep 4, 2024
View reviewed changes
Comment thread pkg/ddl/create_table.go
jackysp
jackysp commented Sep 4, 2024
View reviewed changes
Comment thread pkg/executor/test/ddl/ddl_test.go
Benjamin2037
Benjamin2037 approved these changes Sep 5, 2024
View reviewed changes

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@ti-chi-bot

ti-chi-bot Bot commented Sep 5, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 03:22:47.210870662 +0000 UTC m=+414691.728923572: ☑️ agreed by tangenta.
  • 2024-09-05 01:14:33.066485455 +0000 UTC m=+493397.584538380: ☑️ agreed by Benjamin2037.

@Benjamin2037

Benjamin2037 commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

/hold

@Benjamin2037

Benjamin2037 commented Sep 5, 2024

Copy link
Copy Markdown
Collaborator

@jackysp I just hold this pr and let PM Frank help open an FD for this issue，sync with you！

@ti-chi-bot

ti-chi-bot Bot commented Sep 5, 2024

Copy link
Copy Markdown

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Benjamin2037

Benjamin2037 commented Sep 6, 2024

Copy link
Copy Markdown
Collaborator

/retest

@ti-chi-bot ti-chi-bot Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
@ti-chi-bot

ti-chi-bot Bot commented Sep 6, 2024

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jackysp

jackysp commented Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

@yudongusa PTAL, thanks!

yudongusa
yudongusa approved these changes Sep 13, 2024
View reviewed changes

@yudongusa yudongusa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please don't forget modifying TiDB document.

@ti-chi-bot

ti-chi-bot Bot commented Sep 13, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, Frank945946, tangenta, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 13, 2024
@jackysp

jackysp commented Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2024
@jackysp jackysp removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@ti-chi-bot
ti-chi-bot Bot merged commit 4371a1d into pingcap:master Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes
@tangenta tangenta tangenta approved these changes
@bb7133 bb7133 Awaiting requested review from bb7133
+2 more reviewers
@yudongusa yudongusa yudongusa approved these changes
@Frank945946 Frank945946 Frank945946 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved component/ddl This issue is related to DDL of TiDB. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The default values of shard_row_id_bits and pre_split_regions should be configurable

6 participants

@jackysp @D3Hunter @Frank945946 @Benjamin2037 @tangenta @yudongusa