Enhancement
|
// 8.2 br(store based backup) does not support tikv <= 8.1 |
|
// due to the performance issue https://github.com/tikv/tikv/issues/17168 |
|
// TODO: we can remove this check if the performance issue is fixed and cherry-pick |
|
if (BRVersion.Major > 8 || (BRVersion.Major == 8 && BRVersion.Minor >= 2)) && |
|
(tikvVersion.Major < 8 || (tikvVersion.Major == 8 && tikvVersion.Minor < 2)) { |
|
return errors.Annotatef(berrors.ErrVersionMismatch, "TiKV node %s version %s and BR %s version mismatch, please use the same version of BR", |
|
s.Address, tikvVersion, build.ReleaseVersion) |
|
} |
BR starting from v8.2 rejected interacting with TiKV v8.1 or below even with --check-requirements=false because of tikv/tikv#17168. However, the fix has subsequently cherry-picked back to earlier versions:
So, as promised in the TODO, the check should be tightened to check only v6.5.10- / v7.1.5- / v7.5.2- / v8.1.0 or just entirely removed.
Enhancement
tidb/br/pkg/version/version.go
Lines 245 to 252 in 1f32c8e
BR starting from v8.2 rejected interacting with TiKV v8.1 or below even with
--check-requirements=falsebecause of tikv/tikv#17168. However, the fix has subsequently cherry-picked back to earlier versions:So, as promised in the TODO, the check should be tightened to check only v6.5.10- / v7.1.5- / v7.5.2- / v8.1.0 or just entirely removed.