pdutil: use the correct unit for pausing schedulers#1466
pdutil: use the correct unit for pausing schedulers#1466glorv wants to merge 1 commit intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| func (p *PdController) doPauseSchedulers(ctx context.Context, schedulers []string, post pdHTTPRequest) ([]string, error) { | ||
| // pause this scheduler with 300 seconds | ||
| body, err := json.Marshal(pauseSchedulerBody{Delay: int64(pauseTimeout)}) | ||
| body, err := json.Marshal(pauseSchedulerBody{Delay: int64(pauseTimeout.Seconds())}) |
There was a problem hiding this comment.
or use .Milliseconds() / 1000
nolouch
left a comment
nolouch
left a comment
There was a problem hiding this comment.
lgtm. do we need pick to 6.0?
|
@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is a manually cherry-picked pr as br code with version < 5.2 are still in this repo. |
4 participants
What problem does this PR solve?
ref: pingcap/tidb#33546
What is changed and how it works?
cherry-pick pingcap/tidb#33545 to br
Check List
Tests
Code changes
Side effects
Related changes
Release note