Repository navigation
[diffs] CodeView / WorkerPool Init Race Fix - #911
Conversation
* Fix styles that will break codeview * Add an easy commented out field for the dev check
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d9a565b39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
7d51b42 to
db60319
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d51b423ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex resolve |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0437c659f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
* Smol fixes * Fix styles that will break codeview * Add an easy commented out field for the dev check * Prevent rendering of CodeView before worker pool is initialized * Add test for worker readiness * Smol corrections for annotation errors * Be able to handle a failing worker pool gracefully * PR Review Feedback: Fix up test to use spyOn * PR review feedback: trigger an initialization for the worker pool if needed
Bump the terminal engine from **`@xterm/xterm@6.1.0-beta.300` / `@xterm/addon-webgl@0.20.0-beta.297`** to the latest published betas — **`6.1.0-beta.302` / `0.20.0-beta.298`** — and take the Code tab's diff viewer from **`@pierre/diffs@1.2.12` to `1.3.5`**. kolu rides the xterm 6.1 beta line via `pnpm.overrides` (stable latest is still 6.0.0). Other addons and `@xterm/headless` stay on their package ranges, same as the previous bump (#2130). `@pierre/trees` is already on `1.0.0-beta.6`, its latest tag, so it does not move. Edit mode from Pierre 1.3 is not adopted. ### What's new in xterm.js (since beta.300) | Upstream | What it does for tiles | | --- | --- | | [xtermjs#6081](xtermjs/xterm.js#6081) | After a program clears scrollback with **`ESC[3J`**, the viewport **follows new output** instead of staying pinned to the empty top of the buffer (`isUserScrolling` was left set, so `BufferService.scroll()` refused to advance). | beta.301 is CI-only (release-workflow permissions). WebGL addon **297→298** is that same CI commit; pin it as the live `beta` tag, independently of xterm's suffix. ### What's new in Pierre Diffs (1.2.12 → 1.3.5) The Code tab's vanilla `CodeView` / `FileTree` wrappers compile unchanged. What the viewer picks up: - Syntax highlighting no longer races the worker pool on first open ([pierre#911](pierrecomputer/pierre#911)) - Virtualized rows no longer flash a previous file's header as you scroll ([pierre#740](pierrecomputer/pierre#740)) - Expanding collapsed diff context, and live-updating a diff that's already on screen, both work as they should ([pierre#861](pierrecomputer/pierre#861), [pierre#881](pierrecomputer/pierre#881)) - The viewport keeps its place when a file drops out of a multi-file view ([pierre#1047](pierrecomputer/pierre#1047)); resize handling is hardened ([pierre#1054](pierrecomputer/pierre#1054)) ### This change - `pnpm.overrides`: xterm **300→302**, addon-webgl **297→298** (matched pair of latest betas) - `@pierre/diffs` declared range **^1.2.12 → ^1.3.5** - Refresh `fetchPnpmDeps` hash in `nix/workspace.nix` - Changelog: edit the unreleased xterm note; add a Code-tab Pierre note - `@kolu/xterm-kit` contract suites 94/94 and `@kolu/solid-pierre` 45/45 green on the new pins; typecheck of xterm-kit, solid-pierre, and kolu-client exits 0 ### Try it locally ```sh nix run github:juspay/kolu/chore/deps-xterm-pierre ``` _Generated by Grok Build (model `grok-4.6`)._
Since the release of CodeView, there has been an issue on initialization where CodeView attempts to render before the WorkerPool is ready, which while generally harmless, does end up rendering some zero height containers and does cause some layout validation thrash.
I also found a few areas that I could tighten up with virtualization calculations being properly delayed by a tick (bad). So also potentially improved cases of scrolling into un-measured annotations above.
Fixes #786