Setup - #1
Closed
hal-8999-alpha wants to merge 39 commits into
Closed
Conversation
…cks to see if the server is running
…ty to pass in an index
…orking at first glance.
…plication is stored to local database as well as memory if using the run command
…ks and if the user types open from the command line or the CLI it will list their 5 most recent assets and open the most recent.
…ist it will open the most recent asset and ask them to confirm that they'd like to delete
…lt to assets but if you type list apps it will list what applications you have
mark-at-pieces
left a comment
mark-at-pieces
left a comment
Member
There was a problem hiding this comment.
Took a first scan through on this:
- really glad to see that the SDK is working solid for you!
- I noticed that you have set up an Applications.db, I assume this will be a strategy that will be used to start to cache results from the api? if so would love to chat more about this in our next call
- I noticed that you have the "Code-Detection-API-dev" folder in the PiecesSDK, this was just a started project so would be awesome if you removed this from the repo
- apart from that I have a couple other comments regarding the code within each of the requests however we can also iron those out in the next call as well
Going to be look on publishing the PythonSDK today, should hopefully be up shortly!
… the locally saved asset and open the new. Running 'edit' from the command line will pull up your most recent asset
…'t seem very good
… the actual installed package
….5 with streaming response
… for speed. Fixed closing error with websocket. Fixed formatting error with ask comand.
…ot loop. It answers one question and then closes.
…from command line. Happy path and minor edge cases pass. No obvious errors
Contributor
Author
|
Going to do a new pull request with what I currently have since I feel like we actually reached "setup" |
Merged
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is one main script (app.py) and three libraries for the api calls, commands and gui.
The CLI does a wellness check to ensure the server is running and also stores the current version of Pieces OS to memory.
The CLI has a a working Help command, List by index command which uses assets/identifiers to pull uids and then uses asset/{id} to open an asset by uid. There is also a working Run command which allows the user to run the CLI in a loop. This loop stores the current list of UIDs and the last UID to be opened in memory.