docs: align architecture diagrams with current ADRs#143
Conversation
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (12)
✅ Files skipped from review due to trivial changes (10)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated architecture documentation and governance requiring visual-artifact checklist validation before commit. Regenerated three Excalidraw diagrams (system context, container, module overview) to depict messaging infrastructure shift from Wolverine to Kafka + Schema Registry (events), RabbitMQ (commands/jobs), and gRPC (sync RPC), with strict modulith boundaries and per-module databases. Enhanced development workflow with environment file handling, project-level README with quick-start, and new playbook checklist. ChangesArchitecture Diagrams and Governance
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/diagrams/system-context.excalidraw (1)
1-1955:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRegenerate and commit matching
.svgoutputs for updated Excalidraw sources.This PR updates
.excalidrawsources but does not include regenerated.svgartifacts in the reviewed changes. Please regenerate and commit the corresponding SVG diagrams in the same PR.As per coding guidelines
docs/**/*.excalidraw: Regenerate.svgdiagrams in same PR when.excalidrawsource files change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/diagrams/system-context.excalidraw` around lines 1 - 1955, The PR updated the Excalidraw source docs/diagrams/system-context.excalidraw but did not include the regenerated SVG artifacts; regenerate the corresponding .svg exports for that Excalidraw file (and any other docs/**/*.excalidraw changed in this PR) using Excalidraw (or your export script/CI tool), add the resulting .svg files to the commit, and push/update the PR so the .excalidraw sources and their matching .svg outputs are included together.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/diagrams/system-context.excalidraw`:
- Around line 1-1955: The PR updated the Excalidraw source
docs/diagrams/system-context.excalidraw but did not include the regenerated SVG
artifacts; regenerate the corresponding .svg exports for that Excalidraw file
(and any other docs/**/*.excalidraw changed in this PR) using Excalidraw (or
your export script/CI tool), add the resulting .svg files to the commit, and
push/update the PR so the .excalidraw sources and their matching .svg outputs
are included together.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 396c5316-17b7-4ee0-bed2-151f25daaf03
⛔ Files ignored due to path filters (3)
docs/diagrams/container.svgis excluded by!**/*.svgdocs/diagrams/module-overview.svgis excluded by!**/*.svgdocs/diagrams/system-context.svgis excluded by!**/*.svg
📒 Files selected for processing (5)
docs/diagrams/README.mddocs/diagrams/container.excalidrawdocs/diagrams/generate-diagrams.mjsdocs/diagrams/module-overview.excalidrawdocs/diagrams/system-context.excalidraw
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
Co-authored-by: Phuong Nguyen <phuongnse@users.noreply.github.com>
|
Actionable comments posted: 0 |
Summary
This PR improves architecture diagrams and documentation workflow guardrails, adds a root README entrypoint, hardens ignore rules, and removes redundant doc indirection.
Included changes
system-context,container,module-overview) for semantics, readability, and non-overlapping connector routing.docs/playbooks/visual-artifact-checklist.md.CLAUDE.md,docs/README.md, anddocs/playbooks/wireframes.md.docs/diagrams/.README.mdas project landing page (overview + quick links + local quick start)..gitignore: ignore.env.*with!.env.examplekeep rule..claudeignore: aligned env ignore patterns..dockerignore: clarified intent for excluded paths.docs/diagrams/README.mdas redundant with global docs navigation + shared visual checklist.Linked spec
Requirements & rules followed
> **Implementation status**callouts; deferred items have**Deferred (PR #N follow-up):**lines)dotnet build+dotnet test(fullAxis.sln) +dotnet format --verify-no-changesand/ornpm run ci+npm run testran green for paths touched (N/A: docs/visual/ignore-only changes)PROGRESS.md,TECH_STACK/ patterns as triggered);./scripts/check-doc-drift.shran green locally (N/A: nosrc/,tests/, ordocs/use-cases/AC content changes)patterns.md/ use-case file /TECH_STACK.md/CLAUDE.mdupdated if a new durable rule emergeddocs/WORKAROUNDS.mdwas updated in the same commit and the violation site has a// WORKAROUND: see docs/WORKAROUNDS.md#<slug>commentTODO/FIXME/NotImplementedException/ placeholder / stub undersrc/,tests/,frontend/src/Summary by CodeRabbit
Documentation
Chores