chore(deps): Bump OpenIddict.EntityFrameworkCore from 5.8.0 to 7.5.0#116
chore(deps): Bump OpenIddict.EntityFrameworkCore from 5.8.0 to 7.5.0#116dependabot[bot] wants to merge 1 commit into
Conversation
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughOpenIddict.EntityFrameworkCore package pin in ChangesPackage Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Directory.Packages.props`:
- Around line 92-93: The OpenIddict package family versions are mismatched in
Directory.Packages.props: PackageVersion entries for OpenIddict.AspNetCore
(currently 5.8.0) and OpenIddict.EntityFrameworkCore (7.5.0) must be aligned;
update the OpenIddict.AspNetCore PackageVersion to 7.5.0 (or alternatively
downgrade EntityFrameworkCore to 5.8.0) and then verify all other PackageVersion
entries whose Include starts with "OpenIddict." use the same version so
Axis.Identity.Infrastructure.csproj and Axis.Api.csproj inherit a consistent
OpenIddict version series.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8b0377db-1d4c-4a90-b26a-62785dd9c975
📒 Files selected for processing (1)
Directory.Packages.props
| <PackageVersion Include="OpenIddict.AspNetCore" Version="5.8.0" /> | ||
| <PackageVersion Include="OpenIddict.EntityFrameworkCore" Version="5.8.0" /> | ||
| <PackageVersion Include="OpenIddict.EntityFrameworkCore" Version="7.5.0" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify all OpenIddict package versions are aligned across central and project files.
set -euo pipefail
echo "== OpenIddict versions in central package management =="
rg -nP '<PackageVersion\s+Include="OpenIddict\.[^"]+"\s+Version="[^"]+"' Directory.Packages.props || true
echo
echo "== OpenIddict direct references in project files (if any overrides exist) =="
fd -e csproj -e props -e targets | xargs rg -nP '<PackageReference\s+Include="OpenIddict\.[^"]+"(\s+Version="[^"]+")?' || true
echo
echo "Expected: one consistent major/minor for all OpenIddict.* packages."Repository: phuong-labs/axis
Length of output: 908
🌐 Web query:
Are OpenIddict.AspNetCore 5.8.0 and OpenIddict.EntityFrameworkCore 7.5.0 officially supported together, or must OpenIddict packages be kept on the same major/minor version?
💡 Result:
OpenIddict.AspNetCore 5.8.0 and OpenIddict.EntityFrameworkCore 7.5.0 are not officially supported together; OpenIddict requires the OpenIddict package stack to stay on the same OpenIddict version series (i.e., matching major/minor versions), and you should keep all OpenIddict packages aligned rather than mixing 5.x and 7.x. Evidence: OpenIddict’s own migration docs show both packages updated to the same version number when migrating (e.g., OpenIddict.AspNetCore and OpenIddict.EntityFrameworkCore both set to 5.8.0 in the 4.x→5.x guide, and both set to 7.5.0 in the 6.x→7.x guide) [1][2]. Additionally, OpenIddict’s GitHub repository states that support is only offered for the latest stable version of OpenIddict (implying no support for unsupported mixed-version combinations) [3]. Practical guidance: If you want to use OpenIddict.EntityFrameworkCore 7.5.0, use the corresponding OpenIddict.AspNetCore 7.5.0 (and similarly align Core/client/server/validation packages to 7.5.0) rather than mixing 5.8.0 with 7.5.0 [2][4].
Citations:
- 1: https://documentation.openiddict.com/guides/migration/50-to-60
- 2: https://documentation.openiddict.com/guides/migration/60-to-70
- 3: https://github.com/openiddict/core
- 4: https://documentation.openiddict.com/integrations/aspnet-core.html
Align OpenIddict package family versions before merge.
File: Directory.Packages.props
Lines: 92-93
Snippet showing the final state of code at these lines
<PackageVersion Include="OpenIddict.AspNetCore" Version="5.8.0" />
<PackageVersion Include="OpenIddict.EntityFrameworkCore" Version="7.5.0" />Line 93 upgrades OpenIddict.EntityFrameworkCore to 7.5.0 while Line 92 keeps OpenIddict.AspNetCore at 5.8.0. Since Axis.Identity.Infrastructure.csproj and Axis.Api.csproj reference these packages without explicit versions, they will inherit this mixed setup from Directory.Packages.props, which is a compatibility risk because OpenIddict expects its package stack to stay aligned on the same OpenIddict version series. Align the whole OpenIddict.* family together (recommended: set OpenIddict.AspNetCore to 7.5.0 and ensure any other OpenIddict.* packages match; alternatively keep all OpenIddict packages at 5.8.0).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Directory.Packages.props` around lines 92 - 93, The OpenIddict package family
versions are mismatched in Directory.Packages.props: PackageVersion entries for
OpenIddict.AspNetCore (currently 5.8.0) and OpenIddict.EntityFrameworkCore
(7.5.0) must be aligned; update the OpenIddict.AspNetCore PackageVersion to
7.5.0 (or alternatively downgrade EntityFrameworkCore to 5.8.0) and then verify
all other PackageVersion entries whose Include starts with "OpenIddict." use the
same version so Axis.Identity.Infrastructure.csproj and Axis.Api.csproj inherit
a consistent OpenIddict version series.
ec25534 to
3942503
Compare
--- updated-dependencies: - dependency-name: OpenIddict.EntityFrameworkCore dependency-version: 7.5.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3942503 to
7a2f70f
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updated OpenIddict.EntityFrameworkCore from 5.8.0 to 7.5.0.
Release notes
Sourced from OpenIddict.EntityFrameworkCore's releases.
7.5.0
This release introduces the following changes:
The
ClaimTypes.NameIdentifier,ClaimTypes.NameandClaimTypes.EmailWS-Federation claims manually added toProcessAuthenticationContext.MergedPrincipalare now preserved instead of being overwritten by OpenIddict when mapping OpenID Connect/non-standard claims to their WS-Federation equivalent (thanks @ax0l0tl! ❤️)The
net8.0,net9.0andnet10.0versions of theOpenIddict.Client.DataProtection,OpenIddict.Server.DataProtectionandOpenIddict.Validation.DataProtectionpackages now reference theMicrosoft.AspNetCore.DataProtectionpackage instead of theMicrosoft.AspNetCore.Appframework.Configuration delegates registered by the web provider integrations now run earlier to ensure invalid options are caught without waiting for
IOptionsMonitor<OpenIddictClientOptions>.CurrentValueto be called.All the .NET and third-party dependencies have been updated to their latest version.
7.4.0
This release introduces the following changes:
The new mTLS-based OAuth 2.0 client authentication feature introduced in the previous version can now be used with the standard client credentials grant.
The mTLS token binding implementation was updated to support anonymous clients (in this case, the base
SelfSignedTlsClientAuthenticationPolicyinstance attached to the server options is directly used and theIOpenIddictApplicationManager.GetSelfSignedTlsClientAuthenticationPolicyAsync()/IOpenIddictApplicationManager.ValidateSelfSignedTlsClientCertificateAsync()APIs are not used).The
OpenIddict.Client.SystemIntegrationpackage now restores the ambient request for marshalled authentication demands so that theOpenIddictRequestinstance can be accessed from a custom event handler during a call to theAuthenticateInteractivelyAsync()method.A new
DisableIssuerParameterValidationflag was introduced to allow disabling the built-in logic used to validate theissauthorization response parameter. Due to Google OIDC IdP returns iss parameter without declaring authorization_response_iss_parameter_supported in metadata openiddict/openiddict-core#2428, this flag is set totruefor the Google provider for now.7.3.0
This release introduces the following changes:
Mutual TLS authentication is now fully supported by the server and validation stacks for both OAuth 2.0 client authentication and token binding (mTLS support in the client stack was introduced in OpenIddict 6.0). For more information on how to set up mTLS, read Mutual TLS authentication.
Client secrets are still fully supported but the XML documentation was updated to discourage using them when possible. Instead, developers are encouraged to use either assertion-based client authentication or mTLS-based client authentication, as both offer a higher security level than shared secrets.
Client-side mTLS support was moved from
OpenIddict.Client.SystemNetHttptoOpenIddict.Clientand is now a first-class citizen. As part of this task, the existingTlsClientAuthenticationCertificateSelectorandSelfSignedTlsClientAuthenticationCertificateSelectoroptions present inOpenIddictClientSystemNetHttpOptionsandOpenIddictValidationSystemNetHttpOptionshave been marked as deprecated and are no longer used as they didn't allow flowing certificates dynamically (which is required for mTLS token binding using certificates generated on-the-fly). Instead, developers who need to dynamically override the default TLS client certificates selection logic are now invited to create custom event handlers for theProcessAuthenticationContextevent and use the new*EndpointClientCertificateproperties.OpenIddictClientServicenow allows attaching custom token request parameters viaInteractiveAuthenticationRequest.AdditionalTokenRequestParameters. As part of this change, handling of redirection and post-logout redirection requests by theOpenIddict.Client.SystemIntegrationhas been improved: token and userinfo requests are no longer sent as part of the callback request itself but whenOpenIddictClientService.AuthenticateInteractivelyAsync()is called by the application to finalize the authentication process.OpenIddict now uses 4096-bit RSA keys for development certificates and ephemeral keys (see Bump the key size of RSA keys used to generate ephemeral keys and development certificates openiddict/openiddict-core#2415 for more information).
A new token validation check has been introduced in the client, server and validation stacks to detect when the payload associated with a reference token entry - stolen by a malicious actor from the server database - is directly used instead of the expected reference identifier.
The
osu!service is now supported by theOpenIddict.Client.WebIntegrationpackage (thanks @gehongyan! ❤️).A dedicated
promptsetting was added to the Google web provider (thanks @StellaAlexis! ❤️).An incorrect exception message reference was fixed (thanks @JarieTimmer! ❤️)
The entire code base was updated to use polyfills when targeting older .NET/.NET Framework/.NET Standard targets.
All the .NET and third-party dependencies have been updated to the latest versions.
7.2.0
This release introduces the following changes:
Following today's .NET 10.0 release, all the OpenIddict packages now offer a .NET 10.0 target framework moniker referencing .NET Extensions packages version 10.0.
OpenIddict.Client.WebIntegrationnow supports Figma.The
net8.0-android34.0,net8.0-ios18.0,net8.0-maccatalyst18.0andnet8.0-macos15.0target framework monikers are no longer supported by Microsoft and have been removed from theOpenIddict.Client.SystemIntegrationpackage and theOpenIddictmetapackage. Users of theOpenIddict.Client.SystemIntegrationpackage are invited to migrate to .NET 9.0 or 10.0.OpenIddict*Manager.UpdateAsync()methods have been updated to remove cached entries before callingStore.UpdateAsync()to ensure entities are always removed even when the inner store throws an exception.7.1.0
This release introduces the following changes:
The HeyBoxChat service is now supported by the
OpenIddict.Client.WebIntegrationpackage (thanks @gehongyan! ❤️)New
AddGrantTypePermissions()/RemoveGrantTypePermissions()APIs have been added toOpenIddictApplicationDescriptorto simplify adding and removing grant type permissions for custom grants:7.0.0
For more information about this release, read OpenIddict 7.0 is out.
7.0.0-preview.4
This release introduces the following changes:
x.comendpoints, which avoids forcing users to authenticate ontwitter.combefore being redirected tox.comto continue the authorization process on the new domain.The Alibaba/Battle.net/Cognito/Lark/Zoho providers now throw an exception when an invalid region is configured instead of using the default value when an unrecognized region is explicitly set.
The Zoho provider was updated to support the new United Kingdom region (
https://accounts.zoho.uk/).6.2.1
This release introduces the following changes:
mtls_endpoint_aliasesnode is returned but doesn't include all the supported endpoints (thanks @pctimhk for reporting it! ❤️).6.2.0
This release introduces the following changes:
The client/server/validation ASP.NET Core/OWIN hosts now use
Uri.TryCreate()instead ofnew Uri()to compute the base and request URIs, which avoids throwing an exception when they can't be computed ; for instance when the length of the internal buffer exceeds the limit allowed by the BCLSystem.Uritype (thanks to @tarunmathew12 from the Microsoft Healthcare team for reporting this issue! ❤️)4 new providers have been added to
OpenIddict.Client.WebIntegration:6.1.1
This release introduces the following changes:
client_idparameter to be rejected when enabling end session request caching was fixed (thanks @miegir for reporting it! ❤️)6.1.0
This release introduces the following changes:
request_uriattached. PAR has recently gained traction and is now supported by some OAuth 2.0 services and libraries (including Keycloak and Microsoft's ASP.NET Core OpenID Connect handler starting in .NET 9.0).request_idparameter has been replaced byrequest_uri. While cached requests were persisted usingIDistributedCachein previous versions, they are now stored in request tokens and persisted in OpenIddict's tokens table with the other tokens.OpenIddict.Client.WebIntegrationpackage (thanks @gehongyan and @t1moH1ch! ❤️).The
InteractiveChallengeRequestandInteractiveSignOutRequestmodels have been updated to allow easily attaching an identity token or login hint to authorization and end session requests.The
OpenIddict*AuthorizationStore.PruneAsync()implementations were updated to always exclude permanent authorizations that still have tokens attached, which should reduce risks of seeing SQL exceptions when one of the pruned authorizations still has children entities attached.An issue affecting the
OpenIddictEntityFrameworkCoreAuthorizationStore.FindByApplicationIdAsync()API was identified and fixed (thanks @simon-wacker! ❤️)6.0.0
For more information about this release, read OpenIddict 6.0 general availability.
6.0.0-rc1
This release introduces the following changes:
The OpenIddict server now automatically normalizes unique "amr" claims in identity tokens to ensure a JSON array is always returned (as required by the OpenID Connect specification), even if the developer didn't explicitly use
JsonClaimValueTypes.JsonArrayas the claim value type.New methods allowing to register multiple certificates and keys at once have been added to the client/server/validation builders (thanks @ionite34! ❤️)
Zendesk and EVE Online are now supported by the OpenIddict web providers package (thanks @mozts2005 and @kalaveijo! ❤️)
6.0.0-preview4
This release introduces the following changes:
OpenIddict 6.0 preview 4 was updated to reference the .NET 9.0 RTM packages on .NET 9.0.
The ASP.NET Core and OWIN integrations now include the authentication properties attached to
ProcessAuthenticationContext.Propertiesin errored authentication results, which can be used with the client stack to retrieve custom and non-custom properties attached to thestatetoken when using the "error pass-through mode".OpenIddictClientService.IntrospectTokenAsync()andOpenIddictClientService.RevokeTokenAsync()are now eagerly aborted if the token to introspect or revoke is missing.6.0.0-preview3
This release introduces the following changes:
The existing
IOpenIddictAuthorizationManager.FindAsync(...)andIOpenIddictTokenManager.FindAsync(...)overloads have been merged and replaced by a single method where all the parameters are now optional (for instance, if a nullsubjectvalue is specified when callingIOpenIddictAuthorizationManager.FindAsync(...), the returned collection will contain authorizations for all users).New
IOpenIddictAuthorizationManager.RevokeAsync(...)andIOpenIddictTokenManager.RevokeAsync(...)APIs have been introduced to allow easily revoking authorizations or tokens based on specific parameters. E.g:6.0.0-preview2
This release introduces the following changes:
OpenIddict 6.0 preview 2 was updated to reference the .NET 9.0 RC2 packages on .NET 9.0.
The
OpenIddict.MongoDbandOpenIddict.MongoDb.Modelspackages now referenceMongoDB.DriverandMongoDB.Bson3.0.0 and are now strong-named.Claim.IssuerandClaim.OriginalIssuerproperties. This option is specially useful when using the OpenIddict client in legacy ASP.NET 4.6.2+ applications using ASP.NET Identity, since theClaim.Issuerproperty is directly reflected in the user interface:prompt valuesname used in OpenIddict 6.0 preview 1, theGetPrompts()andHasPrompt()extension have been renamed toGetPromptValues()andHasPromptValue().6.0.0-preview1
This release introduces the following changes:
OpenIddict 6.0 preview 1 now targets .NET 9.0 and references the .NET 9.0 RC1 packages on .NET 9.0 and higher.
The .NET 7.0 and .NET Framework 4.6.1 TFMs have been removed as these versions are no longer supported by Microsoft.
Cryptography endpoint->JSON Web Key Set endpoint.Device endpoint->Device authorization endpoint.Logout endpoint->End-session endpoint.Userinfo endpoint->UserInfo endpoint.Verification endpoint->End-user verification endpoint.tls_client_authorself_signed_tls_client_auth.... (truncated)
Commits viewable in compare view.
Summary by CodeRabbit