Fix bug #55138 PDO OCI cannot insert more than 1332 bytes#633
Closed
gureedo wants to merge 1 commit intophp:masterfrom
gureedo:bug55138
Closed
Fix bug #55138 PDO OCI cannot insert more than 1332 bytes#633gureedo wants to merge 1 commit intophp:masterfrom gureedo:bug55138
gureedo wants to merge 1 commit intophp:masterfrom
gureedo:bug55138
Conversation
Contributor
|
@gureedo would you mind to add a test for it - from code in bug report https://bugs.php.net/bug.php?id=55138 ? |
Author
|
After reading docs more carefully I think implicit value with 4000 bytes is wrong as it does not show real length with different encodings. So we can put into value_sz max value as it type can fit. |
|
Can one of the admins verify this patch? |
Member
|
@gureedo can you fix conflicts please :) Also, can I know the current status of this PR exactly ? |
Author
|
Oops, same issue as in #542. Wating for response. |
Member
|
Please do create a clean PR, closing this one for you. FWIW, I'm not sure why pushing to the branch didn't work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Oracle docs
value_szdefines size in bytes, not characters.OCIBindByName()docs:http://docs.oracle.com/cd/E16655_01/appdev.121/e17625/oci16rel003.htm#LNOCI17140
This fix not covers VARCHAR2 extended mode in new Oracle versions.
See
max_string_size = extendedathttp://docs.oracle.com/cd/E16655_01/appdev.121/e17625/oci03typ.htm#LNOCI16271